Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-28 Thread Alexey Budankov
Hi, On 28.08.2018 11:45, Jiri Olsa wrote: > On Mon, Aug 27, 2018 at 12:02:35PM +0300, Alexey Budankov wrote: >> Hi, >> >> On 27.08.2018 11:33, Jiri Olsa wrote: >>> On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: >>> >>> SNIP >>> diff --git a/tools/perf/util/mmap.c b/tools/per

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-28 Thread Jiri Olsa
On Mon, Aug 27, 2018 at 12:02:35PM +0300, Alexey Budankov wrote: > Hi, > > On 27.08.2018 11:33, Jiri Olsa wrote: > > On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: > > > > SNIP > > > >> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > >> index fc832676a798..e71d46

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Alexey Budankov
Hi, On 27.08.2018 11:33, Jiri Olsa wrote: > On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: > > SNIP > >> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c >> index fc832676a798..e71d46cb01cc 100644 >> --- a/tools/perf/util/mmap.c >> +++ b/tools/perf/util/mmap.c >> @@

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Alexey Budankov
Hi Jiri, On 27.08.2018 11:28, Jiri Olsa wrote: > On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: >> >> The data buffer and accompanying AIO control block are allocated at >> perf_mmap object and the mapped data buffer size is equal to >> the kernel one. >> >> The buffer is then

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Jiri Olsa
On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: SNIP > diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > index fc832676a798..e71d46cb01cc 100644 > --- a/tools/perf/util/mmap.c > +++ b/tools/perf/util/mmap.c > @@ -155,6 +155,10 @@ void __weak auxtrace_mmap_params__set

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Jiri Olsa
On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: > > The data buffer and accompanying AIO control block are allocated at > perf_mmap object and the mapped data buffer size is equal to > the kernel one. > > The buffer is then used to preserve profiling data ready for dumping > a