Re: [PATCH v2 04/14] regulator: SY8106A regulator driver

2016-06-28 Thread Ondřej Jirman
On 27.6.2016 16:54, Mark Brown wrote: > On Sun, Jun 26, 2016 at 05:07:16PM +0200, Ondřej Jirman wrote: >> On 26.6.2016 13:26, Mark Brown wrote: > >>> I'm missing almost all of this series, I've just got this and another >>> patch which look like a standalone driver so it's hard to see any >>> depe

Re: [PATCH v2 04/14] regulator: SY8106A regulator driver

2016-06-27 Thread Mark Brown
On Sat, Jun 25, 2016 at 05:45:01AM +0200, meg...@megous.com wrote: > + config.init_data = of_get_regulator_init_data(dev, dev->of_node, > &sy8106a_reg); > + if (!config.init_data) { > + return -EINVAL; > + } This is broken, constraints are entirely optional - the driver s

Re: [PATCH v2 04/14] regulator: SY8106A regulator driver

2016-06-27 Thread Mark Brown
On Sun, Jun 26, 2016 at 05:07:16PM +0200, Ondřej Jirman wrote: > On 26.6.2016 13:26, Mark Brown wrote: > > I'm missing almost all of this series, I've just got this and another > > patch which look like a standalone driver so it's hard to see any > > dependencies. What's going on here? > Sorry,

Re: [PATCH v2 04/14] regulator: SY8106A regulator driver

2016-06-26 Thread Ondřej Jirman
On 26.6.2016 13:26, Mark Brown wrote: > On Sat, Jun 25, 2016 at 05:45:01AM +0200, meg...@megous.com wrote: >> From: Ondrej Jirman >> >> SY8106A is I2C attached single output voltage regulator >> made by Silergy. > > I'm missing almost all of this series, I've just got this and another > patch whi

Re: [PATCH v2 04/14] regulator: SY8106A regulator driver

2016-06-26 Thread Mark Brown
On Sat, Jun 25, 2016 at 05:45:01AM +0200, meg...@megous.com wrote: > From: Ondrej Jirman > > SY8106A is I2C attached single output voltage regulator > made by Silergy. I'm missing almost all of this series, I've just got this and another patch which look like a standalone driver so it's hard to