Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-08 Thread David Sterba
On Thu, Feb 07, 2019 at 12:36:54PM -0500, Dennis Zhou wrote: > On Thu, Feb 07, 2019 at 05:59:26PM +0100, David Sterba wrote: > > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > > > Dennis Zhou (12): > > > btrfs: add helpers for compression type and level > > > btrfs: rename works

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-07 Thread Dennis Zhou
On Thu, Feb 07, 2019 at 05:59:26PM +0100, David Sterba wrote: > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > > Dennis Zhou (12): > > btrfs: add helpers for compression type and level > > btrfs: rename workspaces_list to workspace_manager > > btrfs: manage heuristic workspace

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-07 Thread David Sterba
On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > Dennis Zhou (12): > btrfs: add helpers for compression type and level > btrfs: rename workspaces_list to workspace_manager > btrfs: manage heuristic workspace as index 0 > btrfs: unify compression ops with workspace_manager >

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-06 Thread Dennis Zhou
On Wed, Feb 06, 2019 at 04:15:52PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 03:48:48PM -0500, Dennis Zhou wrote: > > > Ok great! I'm going to add a v2 for 0012 to add taking the spin_lock > > > just to be safe in cleanup. I should have that ready in a few minutes. > > > > > > > Before

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-06 Thread David Sterba
On Tue, Feb 05, 2019 at 03:48:48PM -0500, Dennis Zhou wrote: > > Ok great! I'm going to add a v2 for 0012 to add taking the spin_lock > > just to be safe in cleanup. I should have that ready in a few minutes. > > > > Before I run v3, are there any other concerns (pending the changes I > made to a

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread Dennis Zhou
On Tue, Feb 05, 2019 at 01:30:27PM -0500, Dennis Zhou wrote: > On Tue, Feb 05, 2019 at 07:27:49PM +0100, David Sterba wrote: > > On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote: > > > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > > > > On Tue, Feb 05, 2019 at 11:30:12

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread Dennis Zhou
On Tue, Feb 05, 2019 at 07:27:49PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote: > > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > > > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > > > > Something is wrong, the pa

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread David Sterba
On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test > > > > > > btrfs/007, without

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread David Sterba
On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test > > > > > btrfs/007, without a stacktrace. V1 was fine and I double checked that > > > > > rc5 itse

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread David Sterba
On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test > > > > btrfs/007, without a stacktrace. V1 was fine and I double checked that > > > > rc5 itself is fine. > > > > > > Hmmm, well that's awkward. I ran xfstests and

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread Dennis Zhou
On Tue, Feb 05, 2019 at 05:27:34PM +0100, David Sterba wrote: > On Tue, Feb 05, 2019 at 11:03:02AM -0500, Dennis Zhou wrote: > > On Tue, Feb 05, 2019 at 03:57:53PM +0100, David Sterba wrote: > > > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > > > > Hi everyone, > > > > > > > > V2

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread David Sterba
On Tue, Feb 05, 2019 at 11:03:02AM -0500, Dennis Zhou wrote: > On Tue, Feb 05, 2019 at 03:57:53PM +0100, David Sterba wrote: > > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > > > Hi everyone, > > > > > > V2 had only a handful of changes outside of minor feedback. > > > 0001: > > >

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread Dennis Zhou
On Tue, Feb 05, 2019 at 03:57:53PM +0100, David Sterba wrote: > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > > Hi everyone, > > > > V2 had only a handful of changes outside of minor feedback. > > 0001: > > - use functions over macros > > 0003: > > - BTRFS_NR_WORKSPACE_MANAGERS is

Re: [PATCH v2 00/12] btrfs: add zstd compression level support

2019-02-05 Thread David Sterba
On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > Hi everyone, > > V2 had only a handful of changes outside of minor feedback. > 0001: > - use functions over macros > 0003: > - BTRFS_NR_WORKSPACE_MANAGERS is added instead of overriding > BTRFS_COMPRESS_TYPES > 0011 (new): > - addres