On Tue, Feb 05, 2019 at 01:30:27PM -0500, Dennis Zhou wrote: > On Tue, Feb 05, 2019 at 07:27:49PM +0100, David Sterba wrote: > > On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote: > > > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote: > > > > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote: > > > > > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test > > > > > > > > btrfs/007, without a stacktrace. V1 was fine and I double > > > > > > > > checked that > > > > > > > > rc5 itself is fine. > > > > > > > > > > > > > > Hmmm, well that's awkward. I ran xfstests and that test passed on > > > > > > > my > > > > > > > machine. I'll figure out the delta and submit a v3. Thanks David! > > > > > > > > > > > > It failed on a VM and 2 other physical machines, so it's not > > > > > > somethig > > > > > > related to the testing setup. > > > > > > > > > > Oh, I wasn't alluding to that. I'm more that sure it's my fault > > > > > somewhere along the line. > > > > > > > > Hang on, it's probably caused by fstests, as fssum is busy waiting > > > > somewhere, so it's not even kernel code. > > > > > > > > fstests a4235f29f780b15d9e87c0f2446a53b9e69c5e2d -- ok > > > > fstests 6d17c9076fe9d97d2411e5909e6b255e5e721fc3 (master) -- hangs > > > > > > Git bisect points to > > > > > > commit 04b405fa1f8d0cacde489f3d1c8771dfe7a34dc0 > > > Author: Zorro Lang <zl...@redhat.com> > > > Date: Wed Jan 23 15:34:55 2019 +0800 > > > > > > common/dump: disable splice from FSSTRESS_AVOID > > > > So with this commit reverted, test btrfs/007 does not hang anymore. > > Ok great! I'm going to add a v2 for 0012 to add taking the spin_lock > just to be safe in cleanup. I should have that ready in a few minutes. >
Before I run v3, are there any other concerns (pending the changes I made to address the mentioned make sense)? Thanks, Dennis
