Re: [PATCH v2 0/3] Teach perf_trace_##call() to check hlist_empty(perf_events)

2013-08-13 Thread Peter Zijlstra
On Mon, Aug 12, 2013 at 07:45:15PM +0200, Oleg Nesterov wrote: > BTW. Can't we kill __perf_addr() and the corresponding argument in > perf_trace_buf_submit/perf_tp_event ? > > Or do you think it can have a new user? Oh, right.. I suppose that was to enable tracepoints for fault (like) events. Cle

Re: [PATCH v2 0/3] Teach perf_trace_##call() to check hlist_empty(perf_events)

2013-08-12 Thread Oleg Nesterov
On 08/12, Peter Zijlstra wrote: > > So I suppose the down-side to putting them in TP_ARGS() is that you > cannot use arbitrary expressions for them anymore; like: > > TP_ARGS(foo); > > TP_perf_assign( > __perf_task(foo->ponies); > __perf_count(foo->horses); > ), > > Not that we actual

Re: [PATCH v2 0/3] Teach perf_trace_##call() to check hlist_empty(perf_events)

2013-08-12 Thread Peter Zijlstra
On Tue, Aug 06, 2013 at 06:08:26PM +0200, Oleg Nesterov wrote: > On 08/05, Steven Rostedt wrote: > > > > > Sorry... should I resend once again ? > > > > Sure, why not. It's only 3 patches :-) > > OK. Added "v2" to avoid the confusion. > > The only change is > > - Reviewed-and-Acked-by: Ste