Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 13, 2020 at 10:38:28AM -0800, Ian Rogers escreveu: > On Fri, Sep 4, 2020 at 9:29 AM Arnaldo Carvalho de Melo > wrote: > > > Em Thu, Sep 03, 2020 at 10:53:16PM -0700, Ian Rogers escreveu: > > > On Thu, Aug 27, 2020 at 12:00 AM kajoljain wrote: > > > > > > > > > > > > > > > > On 8/26/2

Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 03, 2020 at 10:53:16PM -0700, Ian Rogers escreveu: > On Thu, Aug 27, 2020 at 12:00 AM kajoljain wrote: > > > > > > > > On 8/26/20 9:27 PM, Jiri Olsa wrote: > > > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote: > > >> This patch resolves some undefined behavior where variabl

Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

2020-09-03 Thread Ian Rogers
On Thu, Aug 27, 2020 at 12:00 AM kajoljain wrote: > > > > On 8/26/20 9:27 PM, Jiri Olsa wrote: > > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote: > >> This patch resolves some undefined behavior where variables in > >> expr_id_data were accessed (for debugging) without being defined.

Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

2020-08-27 Thread kajoljain
On 8/26/20 9:27 PM, Jiri Olsa wrote: > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote: >> This patch resolves some undefined behavior where variables in >> expr_id_data were accessed (for debugging) without being defined. To >> better enforce the tagged union behavior, the struct is

Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

2020-08-26 Thread Jiri Olsa
On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote: > This patch resolves some undefined behavior where variables in > expr_id_data were accessed (for debugging) without being defined. To > better enforce the tagged union behavior, the struct is moved into > expr.c and accessors provided. T