On Thu, Aug 27, 2020 at 12:00 AM kajoljain <kj...@linux.ibm.com> wrote: > > > > On 8/26/20 9:27 PM, Jiri Olsa wrote: > > On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote: > >> This patch resolves some undefined behavior where variables in > >> expr_id_data were accessed (for debugging) without being defined. To > >> better enforce the tagged union behavior, the struct is moved into > >> expr.c and accessors provided. Tag values (kinds) are explicitly > >> identified. > > Reviewed-By: Kajol Jain<kj...@linux.ibm.com> > > Thanks, > Kajol Jain > >> > >> Signed-off-by: Ian Rogers <irog...@google.com> > > > > great, thanks for doing this > > > > Acked-by: Jiri Olsa <jo...@redhat.com> > > > > jirka > >
Thanks for the reviews! Arnaldo could this get merged? Thanks! Ian
