Re: [PATCH v2] genirq: bug on inconstent flags and flow handler

2014-08-27 Thread Thomas Gleixner
On Tue, 26 Aug 2014, Florian Fainelli wrote: > On 07/23/2014 12:14 PM, Florian Fainelli wrote: > > 2014-07-23 11:49 GMT-07:00 Thomas Gleixner : > >> On Wed, 23 Jul 2014, Florian Fainelli wrote: > >> > >>> It is currently possible for a generic irq chip driver to set IRQ_LEVEL > >>> and have its ir

Re: [PATCH v2] genirq: bug on inconstent flags and flow handler

2014-08-26 Thread Florian Fainelli
On 07/23/2014 12:14 PM, Florian Fainelli wrote: > 2014-07-23 11:49 GMT-07:00 Thomas Gleixner : >> On Wed, 23 Jul 2014, Florian Fainelli wrote: >> >>> It is currently possible for a generic irq chip driver to set IRQ_LEVEL >>> and have its irq flow handler be handle_edge_irq. Setting IRQ_LEVEL in >>

Re: [PATCH v2] genirq: bug on inconstent flags and flow handler

2014-07-23 Thread Jason Cooper
On Wed, Jul 23, 2014 at 08:49:46PM +0200, Thomas Gleixner wrote: > On Wed, 23 Jul 2014, Florian Fainelli wrote: > > > It is currently possible for a generic irq chip driver to set IRQ_LEVEL > > and have its irq flow handler be handle_edge_irq. Setting IRQ_LEVEL in > > such a case does not make sen

Re: [PATCH v2] genirq: bug on inconstent flags and flow handler

2014-07-23 Thread Florian Fainelli
2014-07-23 11:49 GMT-07:00 Thomas Gleixner : > On Wed, 23 Jul 2014, Florian Fainelli wrote: > >> It is currently possible for a generic irq chip driver to set IRQ_LEVEL >> and have its irq flow handler be handle_edge_irq. Setting IRQ_LEVEL in >> such a case does not make sense, and will actually pr

Re: [PATCH v2] genirq: bug on inconstent flags and flow handler

2014-07-23 Thread Thomas Gleixner
On Wed, 23 Jul 2014, Florian Fainelli wrote: > It is currently possible for a generic irq chip driver to set IRQ_LEVEL > and have its irq flow handler be handle_edge_irq. Setting IRQ_LEVEL in > such a case does not make sense, and will actually prevent e.g: the > software resend logic from kicking