On Tue, 26 Aug 2014, Florian Fainelli wrote: > On 07/23/2014 12:14 PM, Florian Fainelli wrote: > > 2014-07-23 11:49 GMT-07:00 Thomas Gleixner <t...@linutronix.de>: > >> On Wed, 23 Jul 2014, Florian Fainelli wrote: > >> > >>> It is currently possible for a generic irq chip driver to set IRQ_LEVEL > >>> and have its irq flow handler be handle_edge_irq. Setting IRQ_LEVEL in > >>> such a case does not make sense, and will actually prevent e.g: the > >>> software resend logic from kicking, and potential other problems too. > >>> > >>> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> > >>> --- > >>> Changes in v2: > >>> - replaced WARN_ON() with BUG_ON() since we really don't want to continue > >>> as suggested by Jason Cooper > >> > >> I disagree here. It's not a reason take the machine down. Its good > >> enough to WARN. That keeps the machine alive and lets us debug that > >> stuff. > > > > Works for me! > > > >> > >> Lemme find V1 .... > > > > Here it is: https://lkml.org/lkml/2014/7/1/468 > > Thomas, do you want me to resubmit that change so you get a clean > submission in your inbox? Thanks
Yes please -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
