Re: [PATCH V3 2/3] perf tool: Move cpumode resolve code to add_callchain_ip

2014-11-21 Thread Arnaldo Carvalho de Melo
; eran...@google.com; linux- > > ker...@vger.kernel.org; mi...@redhat.com; pau...@samba.org; > > a...@linux.intel.com > > Subject: Re: [PATCH V3 2/3] perf tool: Move cpumode resolve code to > > add_callchain_ip > > > > On Fri, Nov 14, 2014 at 08:44:11AM -0500, kan.li

RE: [PATCH V3 2/3] perf tool: Move cpumode resolve code to add_callchain_ip

2014-11-21 Thread Liang, Kan
a...@linux.intel.com > Subject: Re: [PATCH V3 2/3] perf tool: Move cpumode resolve code to > add_callchain_ip > > On Fri, Nov 14, 2014 at 08:44:11AM -0500, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Move the cpumode resolve code to add_callchain_ip functio

Re: [PATCH V3 2/3] perf tool: Move cpumode resolve code to add_callchain_ip

2014-11-18 Thread Jiri Olsa
On Fri, Nov 14, 2014 at 08:44:11AM -0500, kan.li...@intel.com wrote: > From: Kan Liang > > Move the cpumode resolve code to add_callchain_ip function. > No change in behavior. > > Signed-off-by: Kan Liang > --- > tools/perf/util/machine.c | 62 > ++-

Re: [PATCH V3 2/3] perf tool: Move cpumode resolve code to add_callchain_ip

2014-11-17 Thread Jiri Olsa
On Fri, Nov 14, 2014 at 08:44:11AM -0500, kan.li...@intel.com wrote: SNIP > - int i; > - int j; > - int err; > + int i, j, err = 0; > int skip_idx __maybe_unused; > > callchain_cursor_reset(&callchain_cursor); > @@ -1467,39 +1489,13 @@ static int thread__resolve_call

Re: [PATCH V3 2/3] perf tool: Move cpumode resolve code to add_callchain_ip

2014-11-17 Thread Jiri Olsa
On Fri, Nov 14, 2014 at 08:44:11AM -0500, kan.li...@intel.com wrote: > From: Kan Liang SNIP > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1384,11 +1384,35 @@ struct mem_info *sample__resolve_mem(struct > perf_sample *sample, > static int add_callchain_ip(struct thre