Re: [PATCH RFC] virtio_net: enable tx interrupt

2014-10-15 Thread Michael S. Tsirkin
On Wed, Oct 15, 2014 at 07:04:20PM +0800, Jason Wang wrote: > On 10/15/2014 05:53 AM, Michael S. Tsirkin wrote: > > On newer hosts that support delayed tx interrupts, > > we probably don't have much to gain from orphaning > > packets early. > > > > Based on patch by Jason Wang. > > > > Note: this w

Re: [PATCH RFC] virtio_net: enable tx interrupt

2014-10-15 Thread Jason Wang
On 10/15/2014 05:53 AM, Michael S. Tsirkin wrote: > On newer hosts that support delayed tx interrupts, > we probably don't have much to gain from orphaning > packets early. > > Based on patch by Jason Wang. > > Note: this will likely degrade performance for hosts without event idx > support. Vario

Re: [PATCH RFC] virtio_net: enable tx interrupt

2014-10-14 Thread Jason Wang
On 10/15/2014 12:33 PM, Jason Wang wrote: > On 10/15/2014 07:11 AM, Michael S. Tsirkin wrote: >> > On Wed, Oct 15, 2014 at 12:53:59AM +0300, Michael S. Tsirkin wrote: >> > static void skb_xmit_done(struct virtqueue *vq) >> > { >> > struct virtnet_info *vi = vq->vdev->priv; >>

Re: [PATCH RFC] virtio_net: enable tx interrupt

2014-10-14 Thread Jason Wang
On 10/15/2014 07:11 AM, Michael S. Tsirkin wrote: > On Wed, Oct 15, 2014 at 12:53:59AM +0300, Michael S. Tsirkin wrote: >> > static void skb_xmit_done(struct virtqueue *vq) >> > { >> >struct virtnet_info *vi = vq->vdev->priv; >> > + struct send_queue *sq = &vi->sq[vq2txq(vq)]; >> > >> > -

Re: [PATCH RFC] virtio_net: enable tx interrupt

2014-10-14 Thread Michael S. Tsirkin
On Wed, Oct 15, 2014 at 12:53:59AM +0300, Michael S. Tsirkin wrote: > static void skb_xmit_done(struct virtqueue *vq) > { > struct virtnet_info *vi = vq->vdev->priv; > + struct send_queue *sq = &vi->sq[vq2txq(vq)]; > > - /* Suppress further interrupts. */ > - virtqueue_disable