Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment

2015-05-04 Thread Joe Perches
On Mon, 2015-05-04 at 10:51 +0530, Vinod Koul wrote: > On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > > CodingStyle fix only - align function parameters to opening (. > > > This doesnt look any better to me... The goto and return statements were overly indented > > diff --g

Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment

2015-05-03 Thread Nicholas Mc Guire
On Mon, 04 May 2015, Vinod Koul wrote: > On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > > CodingStyle fix only - align function parameters to opening (. > > > This doesnt look any better to me... > True it makes little difference when looking at these few lines I guess thoug

Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment

2015-05-03 Thread Vinod Koul
On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > CodingStyle fix only - align function parameters to opening (. > This doesnt look any better to me... -- ~Vinod > Signed-off-by: Nicholas Mc Guire > --- > > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_