On Mon, 2015-05-04 at 10:51 +0530, Vinod Koul wrote:
> On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote:
> > CodingStyle fix only - align function parameters to opening (.
> > 
> This doesnt look any better to me...

The goto and return statements were overly indented

> > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
[]
> > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int 
> > rlen, int offset)
> >  
> >     /* initiate DMA transfer */
> >     if (flctl->chan_fifo0_rx && rlen >= 32 &&
> > -           flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0)
> > -                   goto convert;   /* DMA success */
> > +       flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0)
> > +           goto convert;   /* DMA success */
> >  
> >     /* do polling transfer */
> >     for (i = 0; i < len_4align; i++) {
> > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, 
> > int rlen,
> >  
> >     /* initiate DMA transfer */
> >     if (flctl->chan_fifo0_tx && rlen >= 32 &&
> > -           flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0)
> > -                   return; /* DMA success */
> > +       flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0)
> > +           return; /* DMA success */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to