Re: [PATCH 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-06-11 Thread Grant Likely
On Mon, 10 Jun 2013 15:50:21 -0700, Rohit Vaswani wrote: > This cleans up the gpio-msm-v2 driver of all the global define usage. > The number of gpios are now defined in the device tree. This enables > adding irqdomain support as well. > > Signed-off-by: Rohit Vaswani Looks good to me. Go ahea

Re: [PATCH 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-22 Thread Rohit Vaswani
On 5/21/2013 2:06 PM, Stephen Boyd wrote: diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 87d5670..f3c1978 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -165,7 +165,7 @@ config GPIO_MSM_V1 config GPIO_MSM_V2 tristate "Qualcomm MSM GPIO v2" - de

Re: [PATCH 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-22 Thread Rohit Vaswani
On 5/22/2013 2:36 AM, Stanimir Varbanov wrote: Hi, Rohit Thanks for the patch! Thanks for the comments... more below On 05/21/2013 09:32 PM, Rohit Vaswani wrote: This cleans up the gpio-msm-v2 driver of all the global define usage. The number of gpios are now defined in the device tree. This

Re: [PATCH 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-22 Thread Stanimir Varbanov
Hi, Rohit Thanks for the patch! On 05/21/2013 09:32 PM, Rohit Vaswani wrote: > This cleans up the gpio-msm-v2 driver of all the global define usage. > The number of gpios are now defined in the device tree. This enables > adding irqdomain support as well. > > Signed-off-by: Rohit Vaswani > ---

Re: [PATCH 3/3] gpio: msm: Add device tree and irqdomain support for gpio-msm-v2

2013-05-21 Thread Stephen Boyd
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 87d5670..f3c1978 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -165,7 +165,7 @@ config GPIO_MSM_V1 > > config GPIO_MSM_V2 > tristate "Qualcomm MSM GPIO v2" > - depends on GPIOLIB && ARCH_MSM > +