Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Christoph Hellwig
On Fri, May 01, 2020 at 11:04:49PM +0100, Al Viro wrote: > Long story - basically, it's been a source of massive headache too many times. > No formal project, but there are several people (me, Arnd, Christoph) who'd > been reducing its use. For more than a decade now, I think... > > FWIW, I doubt

Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Al Viro
On Fri, May 01, 2020 at 02:40:13PM -0700, Andrew Morton wrote: > On Fri, 1 May 2020 22:30:48 +0100 Al Viro wrote: > > > On Fri, May 01, 2020 at 02:19:03PM -0700, Andrew Morton wrote: > > > On Fri, 1 May 2020 12:41:05 +0200 Christoph Hellwig wrote: > > > > > > > Currently copy_string_kernel is

Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Al Viro
On Fri, May 01, 2020 at 09:26:39PM +0200, Christoph Hellwig wrote: > On Fri, May 01, 2020 at 01:50:49PM +0100, Al Viro wrote: > > On Fri, May 01, 2020 at 12:41:05PM +0200, Christoph Hellwig wrote: > > > Currently copy_string_kernel is just a wrapper around copy_strings that > > > simplifies the cal

Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Andrew Morton
On Fri, 1 May 2020 22:30:48 +0100 Al Viro wrote: > On Fri, May 01, 2020 at 02:19:03PM -0700, Andrew Morton wrote: > > On Fri, 1 May 2020 12:41:05 +0200 Christoph Hellwig wrote: > > > > > Currently copy_string_kernel is just a wrapper around copy_strings that > > > simplifies the calling conven

Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Al Viro
On Fri, May 01, 2020 at 02:19:03PM -0700, Andrew Morton wrote: > On Fri, 1 May 2020 12:41:05 +0200 Christoph Hellwig wrote: > > > Currently copy_string_kernel is just a wrapper around copy_strings that > > simplifies the calling conventions and uses set_fs to allow passing a > > kernel pointer.

Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Andrew Morton
On Fri, 1 May 2020 12:41:05 +0200 Christoph Hellwig wrote: > Currently copy_string_kernel is just a wrapper around copy_strings that > simplifies the calling conventions and uses set_fs to allow passing a > kernel pointer. But due to the fact the we only need to handle a single > kernel argumen

Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Christoph Hellwig
On Fri, May 01, 2020 at 01:50:49PM +0100, Al Viro wrote: > On Fri, May 01, 2020 at 12:41:05PM +0200, Christoph Hellwig wrote: > > Currently copy_string_kernel is just a wrapper around copy_strings that > > simplifies the calling conventions and uses set_fs to allow passing a > > kernel pointer. Bu

Re: [PATCH 2/2] exec: open code copy_string_kernel

2020-05-01 Thread Al Viro
On Fri, May 01, 2020 at 12:41:05PM +0200, Christoph Hellwig wrote: > Currently copy_string_kernel is just a wrapper around copy_strings that > simplifies the calling conventions and uses set_fs to allow passing a > kernel pointer. But due to the fact the we only need to handle a single > kernel ar