Re: [PATCH 1/6] clk: asm9260: Fix of_io_request_and_map error check

2015-05-13 Thread Stephen Boyd
On 05/11, Maxime Ripard wrote: > Mike, Stephen, > > On Sat, May 02, 2015 at 05:03:21PM +0200, Maxime Ripard wrote: > > of_io_request_and map returns an error pointer, but the current code assumes > > that on error the returned pointer will be NULL. > > > > Obviously, that makes the check complete

Re: [PATCH 1/6] clk: asm9260: Fix of_io_request_and_map error check

2015-05-11 Thread Maxime Ripard
Mike, Stephen, On Sat, May 02, 2015 at 05:03:21PM +0200, Maxime Ripard wrote: > of_io_request_and map returns an error pointer, but the current code assumes > that on error the returned pointer will be NULL. > > Obviously, that makes the check completely useless. Change the test to > actually >