Re: [PATCH 1/3] Unionfs: use printk KERN_CONT for debugging messages

2008-01-03 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Joe Perches writes: > On Thu, 2008-01-03 at 00:57 -0500, Erez Zadok wrote: > I think printks should be single statements and > KERN_CONT should be used as sparingly as possible. [...] KERN_CONT is documented as not being SMP safe, but I figured it was harmless for

Re: [PATCH 1/3] Unionfs: use printk KERN_CONT for debugging messages

2008-01-02 Thread Joe Perches
On Thu, 2008-01-03 at 00:57 -0500, Erez Zadok wrote: > diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c > index c2b8b58..5f1d887 100644 > --- a/fs/unionfs/debug.c > +++ b/fs/unionfs/debug.c > void __show_inode_times(const struct inode *inode, > @@ -472,15 +473,15 @@ void __show_inode_times(con