In message <[EMAIL PROTECTED]>, Joe Perches writes:
> On Thu, 2008-01-03 at 00:57 -0500, Erez Zadok wrote:
> I think printks should be single statements and
> KERN_CONT should be used as sparingly as possible.
[...]
KERN_CONT is documented as not being SMP safe, but I figured it was harmless
for just some debugging message. Still, I like your way better. Thanks
Joe.
> Perhaps:
> pr_debug("IT(%lu:%d): %s:%s:%d "
> "um=%lu/%lu lm=%lu/%lu "
> "uc=%lu/%lu lc=%lu/%lu\n",
> inode->i_ino, bindex, file, fnx, line,
> inode->i_mtime.tv_sec, inode->i_mtime.tv_nsec,
> lower_inode->i_mtime.tv_sec,
> lower_inode->i_mtime.tv_nsec
> inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec,
> lower_inode->i_ctime.tv_sec,
> lower_inode->i_ctime.tv_nsec);
[...]
Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
