Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-30 Thread Russell King - ARM Linux
On Thu, Aug 29, 2013 at 01:01:23PM +0200, Sebastian Hesselbarth wrote: > Taking the sound node above: > > sound { > compatible = "whatever-audio"; > ... > audio-codec = <&rt1234 1>, <&spdif 0>; > audio-codec-names = "i2s", "spdifo"; > ... > }; > > Each audio-codec phan

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Russell King - ARM Linux
On Thu, Aug 29, 2013 at 07:20:11PM +0100, Mark Brown wrote: > On Thu, Aug 29, 2013 at 08:02:27PM +0200, Sebastian Hesselbarth wrote: > > > > it is referring the same differences Russell already mentioned. But I > > already came to the conclusion, that we don't need the information in > > the bindi

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Mark Brown
On Thu, Aug 29, 2013 at 08:02:27PM +0200, Sebastian Hesselbarth wrote: > > it is referring the same differences Russell already mentioned. But I > already came to the conclusion, that we don't need the information in > the binding. For example, if you use that controller on Dove and you > hook it

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Sebastian Hesselbarth
On 08/29/13 19:12, Mark Brown wrote: On Thu, Aug 29, 2013 at 05:33:58PM +0100, Russell King - ARM Linux wrote: On Thu, Aug 29, 2013 at 05:12:17PM +0100, Mark Brown wrote: On Wed, Aug 28, 2013 at 12:26:31PM +0200, Sebastian Hesselbarth wrote: Also, we'll need to distinguish between the differ

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Mark Brown
On Thu, Aug 29, 2013 at 05:33:58PM +0100, Russell King - ARM Linux wrote: > On Thu, Aug 29, 2013 at 05:12:17PM +0100, Mark Brown wrote: > > On Wed, Aug 28, 2013 at 12:26:31PM +0200, Sebastian Hesselbarth wrote: > > > Also, we'll need to distinguish between the different audio controllers > > > on

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Russell King - ARM Linux
On Thu, Aug 29, 2013 at 05:12:17PM +0100, Mark Brown wrote: > Why is this required - ideally this would have been mentioned in some of > the previous reviews... I've mentioned the differences between the blocks to you repeatedly in our massive thread, including that some contain the block with dif

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Mark Brown
On Wed, Aug 28, 2013 at 12:26:31PM +0200, Sebastian Hesselbarth wrote: > Unfortunately, mvebu-audio has already been taken by Mark. Also, we > know the differences for the three SoCs now and should have a compatible > for each (and maybe mvebu-audio for fallback). We're not at the merge window ye

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Sergei Shtylyov
Hello. On 29-08-2013 13:38, Jean-Francois Moine wrote: diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi index 499abad..78227e2 100644 --- a/arch/arm/boot/dts/dove.dtsi +++ b/arch/arm/boot/dts/dove.dtsi @@ -573,6 +573,24 @@ phy-handle

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Sebastian Hesselbarth
On 08/29/13 12:13, Russell King - ARM Linux wrote: On Thu, Aug 29, 2013 at 12:07:04PM +0200, Jean-Francois Moine wrote: On Wed, 28 Aug 2013 14:16:32 +0200 Sebastian Hesselbarth wrote: [snip] Though, if the difference between the two units is the availability of SPDIF support, then we

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Russell King - ARM Linux
On Thu, Aug 29, 2013 at 12:07:04PM +0200, Jean-Francois Moine wrote: > On Wed, 28 Aug 2013 14:16:32 +0200 > Sebastian Hesselbarth wrote: > > [snip] > > > Though, if the difference between the two units is the availability of > > > SPDIF support, then we shouldn't encode the channel number,

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Jean-Francois Moine
On Wed, 28 Aug 2013 14:16:32 +0200 Sebastian Hesselbarth wrote: [snip] > > Though, if the difference between the two units is the availability of > > SPDIF support, then we shouldn't encode the channel number, but instead > > the availability of SPDIF, i.e: > > > > audio0 { > >

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Jean-Francois Moine
On Wed, 28 Aug 2013 13:15:48 +0200 Thomas Petazzoni wrote: > For what reason does the driver needs to know whether it's the instance > 0 or instance 1 ? If it's needed for some specific reason, then there > should probably be something like marvell,i2s-channel-id = <0> and > marvell,i2s-channel-i

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-29 Thread Jean-Francois Moine
On Wed, 28 Aug 2013 23:49:12 +0400 Sergei Shtylyov wrote: > > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > > index 499abad..78227e2 100644 > > --- a/arch/arm/boot/dts/dove.dtsi > > +++ b/arch/arm/boot/dts/dove.dtsi > > @@ -573,6 +573,24 @@ > >

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Sergei Shtylyov
Hello. On 08/28/2013 01:34 PM, Jean-Francois Moine wrote: This patch adds the nodes to instantiate the audio devices of the Dove boards. Signed-off-by: Jean-Francois Moine --- arch/arm/boot/dts/dove.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff -

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Russell King - ARM Linux
On Wed, Aug 28, 2013 at 02:51:51PM +0200, Thomas Petazzoni wrote: > I don't see how this makes this a different situation. See for example > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/161065.html > and > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-March/087702.h

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Thomas Petazzoni
Dear Russell King - ARM Linux, On Wed, 28 Aug 2013 13:42:55 +0100, Russell King - ARM Linux wrote: > > Using the name of the oldest SoC in the family that had the IP block is > > the norm, because it's really what "compatible" means: the IP block in > > Dove is *compatible* with the one that was

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Russell King - ARM Linux
On Wed, Aug 28, 2013 at 02:29:09PM +0200, Thomas Petazzoni wrote: > Dear Russell King - ARM Linux, > > On Wed, 28 Aug 2013 13:13:20 +0100, Russell King - ARM Linux wrote: > > > > > I guess, yes. > > > > > > Jean-François, could you cook and submit a patch to change the > > > compatible string? >

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Thomas Petazzoni
Dear Russell King - ARM Linux, On Wed, 28 Aug 2013 13:13:20 +0100, Russell King - ARM Linux wrote: > > > I guess, yes. > > > > Jean-François, could you cook and submit a patch to change the > > compatible string? > > I don't think this is a good idea. The configuration of this IP is > not base

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Sebastian Hesselbarth
On 08/28/13 13:58, Thomas Petazzoni wrote: On Wed, 28 Aug 2013 13:44:51 +0200, Sebastian Hesselbarth wrote: Also, we'll need to distinguish between the different audio controllers on a single SoC, i.e. i2s0 and i2s1. I suggest checking the (phys) reg base passed. For what reason does the drive

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Russell King - ARM Linux
On Wed, Aug 28, 2013 at 01:58:27PM +0200, Thomas Petazzoni wrote: > Dear Sebastian Hesselbarth, > > On Wed, 28 Aug 2013 13:44:51 +0200, Sebastian Hesselbarth wrote: > > > > For 3.12, right? So 3.12 hasn't been released yet, so it's still time > > > to fix this. > > > > I guess, yes. > > Jean-Fr

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Wed, 28 Aug 2013 13:44:51 +0200, Sebastian Hesselbarth wrote: > > For 3.12, right? So 3.12 hasn't been released yet, so it's still time > > to fix this. > > I guess, yes. Jean-François, could you cook and submit a patch to change the compatible string? > >> Also,

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Sebastian Hesselbarth
On 08/28/13 13:15, Thomas Petazzoni wrote: On Wed, 28 Aug 2013 12:26:31 +0200, Sebastian Hesselbarth wrote: as Mark Brown already took the bindings patch for above generic compatible, how are we going to discriminate different implementations/features of Dove, Kirkwood, and Armada 370? I agree

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Wed, 28 Aug 2013 12:26:31 +0200, Sebastian Hesselbarth wrote: > >> as Mark Brown already took the bindings patch for above generic > >> compatible, how are we going to discriminate different > >> implementations/features of Dove, Kirkwood, and Armada 370? > > > > I

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Sebastian Hesselbarth
On 08/28/2013 12:19 PM, Thomas Petazzoni wrote: Sebastian, Jean-François, On Wed, 28 Aug 2013 12:13:07 +0200, Sebastian Hesselbarth wrote: On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: This patch adds the nodes to instantiate the audio devices of the Dove boards. Signed-off-by: Jean-Fran

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Thomas Petazzoni
Sebastian, Jean-François, On Wed, 28 Aug 2013 12:13:07 +0200, Sebastian Hesselbarth wrote: > On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: > > This patch adds the nodes to instantiate the audio devices of the Dove > > boards. > > > > Signed-off-by: Jean-Francois Moine > > --- > > arch/arm/

Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

2013-08-28 Thread Sebastian Hesselbarth
On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: This patch adds the nodes to instantiate the audio devices of the Dove boards. Signed-off-by: Jean-Francois Moine --- arch/arm/boot/dts/dove.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/a