Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT

[Jean-Francois Moine]

On Wed, 28 Aug 2013 23:49:12 +0400
Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote:

> > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> > index 499abad..78227e2 100644
> > --- a/arch/arm/boot/dts/dove.dtsi
> > +++ b/arch/arm/boot/dts/dove.dtsi
> > @@ -573,6 +573,24 @@
> >                                     phy-handle = <&ethphy>;
> >                             };
> >                     };
> > +
> > +                   i2s0: audio-controller@b0000 {  
> 
>      According to ePAPR [1] the node should be called "sound", not 
> "audio-controller".
> 
> > +                           compatible = "marvell,mvebu-audio";
> > +                           reg = <0xb0000 0x2210>;
> > +                           interrupts = <19>, <20>;
> > +                           clocks = <&gate_clk 12>;
> > +                           clock-names = "internal";
> > +                           status = "disabled";
> > +                   };

AFAIK, "sound" describes the global audio subsystem. For the Cubox,
this will be done by something like:

        sound {
                compatible = "simple-audio";
                audio-controller = <&i2s1>;
                audio-codec = <&spdif>;
                codec-dai-name = "dit-hifi";
        };

-- 
Ken ar c'hentañ |             ** Breizh ha Linux atav! **
Jef             |               http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/