Re: [PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable.

2018-10-09 Thread Leonardo Bras
Thank you! Please let me know if it needs any rework! Leonardo Bras On Sat, Oct 6, 2018 at 4:50 PM Masahiro Yamada wrote: > > Hi Leonardo, David, > > > > On Fri, Oct 5, 2018 at 11:32 AM Leonardo Bras wrote: > > > > Hello David, > > > > My name is Leonardo and I am new to kernel development. >

Re: [PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable.

2018-10-06 Thread Masahiro Yamada
Hi Leonardo, David, On Fri, Oct 5, 2018 at 11:32 AM Leonardo Bras wrote: > > Hello David, > > My name is Leonardo and I am new to kernel development. > > Is this patch acceptable? Do it need some rework? The change makes sense? > Is there a way to better follow the workflow for this patch? > >

Re: [PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable.

2018-10-04 Thread Leonardo Bras
Hello David, My name is Leonardo and I am new to kernel development. Is this patch acceptable? Do it need some rework? The change makes sense? Is there a way to better follow the workflow for this patch? Please let me know if it needs anything. Best regards, Leonardo Bras On Wed, Sep 19, 2018

Re: [PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable.

2018-09-19 Thread Masahiro Yamada
FW: David Howells 2018-09-19 8:00 GMT+09:00 Leonardo Brás : > Removes an unnecessary shadowed local variable (start). > Optimize test of isdigit: > - If isalpha returns true, isdigit will return false, so no need to test. > > Signed-off-by: Leonardo Brás This patch was sent to me, but maybe be