FW: David Howells
2018-09-19 8:00 GMT+09:00 Leonardo Brás <leobra...@gmail.com>: > Removes an unnecessary shadowed local variable (start). > Optimize test of isdigit: > - If isalpha returns true, isdigit will return false, so no need to test. > > Signed-off-by: Leonardo Brás <leobra...@gmail.com> This patch was sent to me, but maybe belong to David's field. David, will you take care of this patch? https://lore.kernel.org/patchwork/patch/988171/ I think the commit subject should be changed kbuild: -> ASN.1: Anyway, this patch looks trivial, FWIW Reviewed-by: Masahiro Yamada <yamada.masah...@socionext.com> > --- > scripts/asn1_compiler.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c > index c146020fc783..a0056df4e358 100644 > --- a/scripts/asn1_compiler.c > +++ b/scripts/asn1_compiler.c > @@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end) > > /* Handle string tokens */ > if (isalpha(*p)) { > - const char **dir, *start = p; > + const char **dir; > > /* Can be a directive, type name or element > * name. Find the end of the name. > @@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end) > > tokens[tix++].token_type = TOKEN_TYPE_NAME; > continue; > - } > > - /* Handle numbers */ > - if (isdigit(*p)) { > + } else if (isdigit(*p)) { > + /* Handle numbers */ > + > /* Find the end of the number */ > q = p + 1; > while (q < nl && (isdigit(*q))) > -- > 2.19.0 > -- Best Regards Masahiro Yamada
