Re: [PATCH] ww_mutex: convert self-test to KUnit

2025-02-12 Thread Dan Carpenter
On Wed, Feb 12, 2025 at 09:33:46AM -0500, Tamir Duberstein wrote: > > > > As an aside, how can I compile with the warning settings used by > kernel test robot? > This is a Smatch warning. https://github.com/error27/smatch https://github.com/error27/smatch/blob/master/Documentation/smatch.rst R

Re: [PATCH] ww_mutex: convert self-test to KUnit

2025-02-12 Thread Tamir Duberstein
Hi Dan, On Wed, Feb 12, 2025 at 6:53 AM Dan Carpenter wrote: > > Hi Tamir, > > kernel test robot noticed the following build warnings: > > url: > https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/ww_mutex-convert-self-test-to-KUnit/20250211-000245 > base: a64dcfb451e254085a7da

Re: [PATCH] ww_mutex: convert self-test to KUnit

2025-02-12 Thread Dan Carpenter
Hi Tamir, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/ww_mutex-convert-self-test-to-KUnit/20250211-000245 base: a64dcfb451e254085a7daee5fe51bf22959d52d3 patch link: https://lore.kernel.org/r/20250210-ww_mut

Re: [PATCH] ww_mutex: convert self-test to KUnit

2025-02-12 Thread David Gow
On Wed, 12 Feb 2025 at 06:43, Tamir Duberstein wrote: > > On Tue, Feb 11, 2025 at 5:38 PM Boqun Feng wrote: > > > > Hi Tamir, > > Hi Boqun, thanks for taking a look. > > > On Mon, Feb 10, 2025 at 10:59:12AM -0500, Tamir Duberstein wrote: > > > Convert this unit test to a KUnit test. > > > > > > >

Re: [PATCH] ww_mutex: convert self-test to KUnit

2025-02-11 Thread Tamir Duberstein
On Tue, Feb 11, 2025 at 5:38 PM Boqun Feng wrote: > > Hi Tamir, Hi Boqun, thanks for taking a look. > On Mon, Feb 10, 2025 at 10:59:12AM -0500, Tamir Duberstein wrote: > > Convert this unit test to a KUnit test. > > > > I would like to know the pros and cons between kunit tests and > kselftests,

Re: [PATCH] ww_mutex: convert self-test to KUnit

2025-02-11 Thread Boqun Feng
Hi Tamir, On Mon, Feb 10, 2025 at 10:59:12AM -0500, Tamir Duberstein wrote: > Convert this unit test to a KUnit test. > I would like to know the pros and cons between kunit tests and kselftests, maybe someone Cced can answer that? It'll be good to put these in the commit log as well. Regards, B