Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-19 Thread Evgeniy Dushistov
On Tue, Feb 19, 2008 at 06:45:42PM +0100, Marcin Slusarz wrote: > On Tue, Feb 19, 2008 at 12:22:19AM +0100, Roel Kluin wrote: > > Andrew Morton wrote: > > > On Wed, 13 Feb 2008 10:41:44 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > > > > > >> you may also want these: > > >> --- > > >> [bl]e_add_cp

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2008 at 12:22:19AM +0100, Roel Kluin wrote: > Andrew Morton wrote: > > On Wed, 13 Feb 2008 10:41:44 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > > > >> you may also want these: > >> --- > >> [bl]e_add_cpu conversion in return > > > upsets powerpc (at least): > > > > fs/ufs/swab.

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-18 Thread Roel Kluin
Andrew Morton wrote: > On Wed, 13 Feb 2008 10:41:44 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > >> you may also want these: >> --- >> [bl]e_add_cpu conversion in return > upsets powerpc (at least): > > fs/ufs/swab.h: In function `fs64_add': > fs/ufs/swab.h:47: warning: passing arg 1 of `le64_a

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-15 Thread Andrew Morton
On Wed, 13 Feb 2008 10:41:44 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > you may also want these: > --- > [bl]e_add_cpu conversion in return > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/fs/ufs/swab.h b/fs/ufs/swab.h > index 1683d2b..a1e3000 100644 > --- a/fs/ufs/swab.h

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-13 Thread Marcin Slusarz
On Wed, Feb 13, 2008 at 10:41:44AM +0100, Roel Kluin wrote: > [EMAIL PROTECTED] wrote: > > replace all: > > big/little_endian_variable = > > cpu_to_[bl]eX([bl]eX_to_cpu(big/little_endian_variable) + > > expression_in_cpu_byteorder); > > with: > > [bl]eX_add_

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-13 Thread Roel Kluin
[EMAIL PROTECTED] wrote: > replace all: > big/little_endian_variable = > cpu_to_[bl]eX([bl]eX_to_cpu(big/little_endian_variable) + > expression_in_cpu_byteorder); > with: > [bl]eX_add_cpu(&big/little_endian_variable, > expression_in_cpu_byteorder); you