Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-07-10 Thread Joel Fernandes
On Tue, Jul 10, 2018 at 09:44:57PM -0400, Steven Rostedt wrote: > On Wed, 2 May 2018 10:12:14 +1000 > Nicholas Piggin wrote: > > > > I have mixed feelings about this patch, I am Ok with this patch but I > > > suggest its sent with the follow-up patch that shows its use of this. > > > And also app

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-07-10 Thread Steven Rostedt
On Wed, 2 May 2018 10:12:14 +1000 Nicholas Piggin wrote: > > I have mixed feelings about this patch, I am Ok with this patch but I > > suggest its sent with the follow-up patch that shows its use of this. > > And also appreciate if such a follow-up patch is rebased onto the IRQ > > tracepoint wor

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-05-01 Thread Nicholas Piggin
On Tue, 1 May 2018 14:15:14 -0700 Joel Fernandes wrote: > On Tue, May 1, 2018 at 1:00 PM, Steven Rostedt wrote: > > On Tue, 1 May 2018 21:48:38 +0200 > > Peter Zijlstra wrote: > > > >> On Tue, May 01, 2018 at 03:38:40PM -0400, Steven Rostedt wrote: > >> > On Tue, 1 May 2018 21:19:51 +0200 >

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-05-01 Thread Joel Fernandes
On Tue, May 1, 2018 at 1:00 PM, Steven Rostedt wrote: > On Tue, 1 May 2018 21:48:38 +0200 > Peter Zijlstra wrote: > >> On Tue, May 01, 2018 at 03:38:40PM -0400, Steven Rostedt wrote: >> > On Tue, 1 May 2018 21:19:51 +0200 >> > Peter Zijlstra wrote: >> >> > > Now, lockdep only minimally tracks th

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-05-01 Thread Steven Rostedt
On Tue, 1 May 2018 21:48:38 +0200 Peter Zijlstra wrote: > On Tue, May 01, 2018 at 03:38:40PM -0400, Steven Rostedt wrote: > > On Tue, 1 May 2018 21:19:51 +0200 > > Peter Zijlstra wrote: > > > > Now, lockdep only minimally tracks these otherwise redundant operations; > > > see redundant_hardir

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-05-01 Thread Peter Zijlstra
On Tue, May 01, 2018 at 03:38:40PM -0400, Steven Rostedt wrote: > On Tue, 1 May 2018 21:19:51 +0200 > Peter Zijlstra wrote: > > Now, lockdep only minimally tracks these otherwise redundant operations; > > see redundant_hardirqs_{on,off} counters, and loosing that doesn't seen > > like a big issue

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-05-01 Thread Steven Rostedt
On Tue, 1 May 2018 21:19:51 +0200 Peter Zijlstra wrote: > On Tue, May 01, 2018 at 02:46:20PM -0400, Steven Rostedt wrote: > > On Fri, 17 Nov 2017 02:15:06 +1000 > > Nicholas Piggin wrote: > > > > > In local_irq_save and local_irq_restore, only call irq tracing when > > > the flag state acutal

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-05-01 Thread Peter Zijlstra
On Tue, May 01, 2018 at 02:46:20PM -0400, Steven Rostedt wrote: > On Fri, 17 Nov 2017 02:15:06 +1000 > Nicholas Piggin wrote: > > > In local_irq_save and local_irq_restore, only call irq tracing when > > the flag state acutally changes. It is not unexpected for the state > > to go disable->disabl

Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes

2018-05-01 Thread Steven Rostedt
On Fri, 17 Nov 2017 02:15:06 +1000 Nicholas Piggin wrote: > In local_irq_save and local_irq_restore, only call irq tracing when > the flag state acutally changes. It is not unexpected for the state > to go disable->disable. > > This allows the irq tracing code to better track superfluous > enabl