On Thu, Oct 05 2000, Jeff Garzik wrote:
> * return value from pci_module_init and TLan_EisaProbe is never checked.
> If you don't care about the return value, just remove 'rc' var.
>
I was going to have some code here, but haven't had the time. I'll
remove it.
> * does TLan_EisaProbe work? It l
On Thu, Oct 05 2000, Tigran Aivazian wrote:
> Hi Torben,
>
> Just a tiny comment - maybe you noticed the recent "trend" in moving
> zero-initialised data out of data into where it belongs, i.e. bss. Your
> patch does a little bit to the contrary, namely bits like:
>
> +static struct net_device
As tigran mentions, you should not explicitly zero static vars.
You need to ask yourself if TLAN will -ever- be used in a hotplug
situation, ie. do you find TLAN hardware on CardBus or PCMCIA cards?
If no, you should:
s/__devinit/__init/
s/__devexit/__exit/
If yes, you have so
On Thu, 5 Oct 2000, Torben Mathiasen wrote:
> Linus,
>
> This patch includes the following:
>
> Fixes the timer being added twice bug (on tytso's list)
> Convertes driver to new PCI layout
> Adds support for EISA based TLAN adapters.
>
> Patch has been tested for over a month
4 matches
Mail list logo