On Thu, 5 Oct 2000, Torben Mathiasen wrote:

> Linus,
> 
> This patch includes the following:
> 
>       Fixes the timer being added twice bug (on tytso's list)
>       Convertes driver to new PCI layout
>       Adds support for EISA based TLAN adapters.
> 
> Patch has been tested for over a month now and is ready for 2.4.
> 
> Against final test9.
> 

Hi Torben,

Just a tiny comment - maybe you noticed the recent "trend" in moving
zero-initialised data out of data into where it belongs, i.e. bss. Your
patch does a little bit to the contrary, namely bits like:

+static struct net_device       *TLan_Eisa_Devices = NULL;

....

+static int tlan_have_pci = 0;
+static int tlan_have_eisa = 0;

etc.

Regards,
Tigran


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/

Reply via email to