Re: [PATCH] swap: redirty page if page write fails on swap file

2013-05-03 Thread Jerome Marchand
On 05/01/2013 09:39 AM, Simon Jeons wrote: > Ping, ;-) > On 04/18/2013 08:13 AM, Simon Jeons wrote: >> Hi Jerome, >> On 04/17/2013 08:11 PM, Jerome Marchand wrote: >>> Since commit 62c230b, swap_writepage() calls direct_IO on swap files. >>> However, in that case page isn't redirtied if I/O fails,

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-05-01 Thread Simon Jeons
Ping, ;-) On 04/18/2013 08:13 AM, Simon Jeons wrote: Hi Jerome, On 04/17/2013 08:11 PM, Jerome Marchand wrote: Since commit 62c230b, swap_writepage() calls direct_IO on swap files. However, in that case page isn't redirtied if I/O fails, and is therefore handled afterwards as if it has been su

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-05-01 Thread Will Huck
Hi Jerome, On 04/24/2013 05:57 PM, Jerome Marchand wrote: On 04/22/2013 10:37 PM, Andrew Morton wrote: On Wed, 17 Apr 2013 14:11:55 +0200 Jerome Marchand wrote: Since commit 62c230b, swap_writepage() calls direct_IO on swap files. However, in that case page isn't redirtied if I/O fails, and i

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-04-24 Thread Jerome Marchand
On 04/22/2013 10:37 PM, Andrew Morton wrote: > On Wed, 17 Apr 2013 14:11:55 +0200 Jerome Marchand > wrote: > >> >> Since commit 62c230b, swap_writepage() calls direct_IO on swap files. >> However, in that case page isn't redirtied if I/O fails, and is therefore >> handled afterwards as if it has

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-04-22 Thread Andrew Morton
On Wed, 17 Apr 2013 14:11:55 +0200 Jerome Marchand wrote: > > Since commit 62c230b, swap_writepage() calls direct_IO on swap files. > However, in that case page isn't redirtied if I/O fails, and is therefore > handled afterwards as if it has been successfully written to the swap > file, leading

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-04-17 Thread Simon Jeons
Hi Jerome, On 04/17/2013 08:11 PM, Jerome Marchand wrote: Since commit 62c230b, swap_writepage() calls direct_IO on swap files. However, in that case page isn't redirtied if I/O fails, and is therefore handled afterwards as if it has been successfully written to the swap file, leading to memory c

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-04-17 Thread Mel Gorman
On Wed, Apr 17, 2013 at 02:11:55PM +0200, Jerome Marchand wrote: > > Since commit 62c230b, swap_writepage() calls direct_IO on swap files. > However, in that case page isn't redirtied if I/O fails, and is therefore > handled afterwards as if it has been successfully written to the swap > file, lea

Re: [PATCH] swap: redirty page if page write fails on swap file

2013-04-17 Thread Johannes Weiner
On Wed, Apr 17, 2013 at 02:11:55PM +0200, Jerome Marchand wrote: > > Since commit 62c230b, swap_writepage() calls direct_IO on swap files. > However, in that case page isn't redirtied if I/O fails, and is therefore > handled afterwards as if it has been successfully written to the swap > file, lea