Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-20 Thread Sam Ravnborg
On Wed, Jun 20, 2007 at 04:53:15PM +0100, Paulo Marques wrote: > Segher Boessenkool wrote: > So we could remove the "#define _GNU_SOURCE" at the top > of scripts/kallsyms.c too, presumably? If not (i.e. if there are > more GNUisms left in that file anyway), then I'm not sure if we > >>>

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-20 Thread Paulo Marques
Segher Boessenkool wrote: So we could remove the "#define _GNU_SOURCE" at the top of scripts/kallsyms.c too, presumably? If not (i.e. if there are more GNUisms left in that file anyway), then I'm not sure if we really gain by the change. yes, i believe this is true I only tried in on x86 with

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-20 Thread Segher Boessenkool
So we could remove the "#define _GNU_SOURCE" at the top of scripts/kallsyms.c too, presumably? If not (i.e. if there are more GNUisms left in that file anyway), then I'm not sure if we really gain by the change. yes, i believe this is true I only tried in on x86 with my toolchain and it works,

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-20 Thread Paulo Marques
Mike Frysinger wrote: On Tuesday 19 June 2007, Satyam Sharma wrote: So we could remove the "#define _GNU_SOURCE" at the top of scripts/kallsyms.c too, presumably? If not (i.e. if there are more GNUisms left in that file anyway), then I'm not sure if we really gain by the change. yes, i believe

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-20 Thread Paulo Marques
Christoph Hellwig wrote: On Tue, Jun 19, 2007 at 05:15:56PM +0100, Paulo Marques wrote: The only in-kernel user of "memmem" is scripts/kallsyms.c and it only uses it to find tokens that are 2 bytes in size. It is trivial to replace it with a simple function that finds 2-byte tokens. This shou

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-19 Thread Mike Frysinger
On Tuesday 19 June 2007, Satyam Sharma wrote: > On 6/19/07, Paulo Marques <[EMAIL PROTECTED]> wrote: > > The only in-kernel user of "memmem" is scripts/kallsyms.c and it only > > uses it to find tokens that are 2 bytes in size. It is trivial to > > replace it with a simple function that finds 2-byt

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-19 Thread Christoph Hellwig
On Tue, Jun 19, 2007 at 05:15:56PM +0100, Paulo Marques wrote: > > The only in-kernel user of "memmem" is scripts/kallsyms.c and it only > uses it to find tokens that are 2 bytes in size. It is trivial to > replace it with a simple function that finds 2-byte tokens. > > This should help users f

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-19 Thread Satyam Sharma
Hi, On 6/19/07, Paulo Marques <[EMAIL PROTECTED]> wrote: The only in-kernel user of "memmem" is scripts/kallsyms.c and it only uses it to find tokens that are 2 bytes in size. It is trivial to replace it with a simple function that finds 2-byte tokens. This should help users from systems that

Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

2007-06-19 Thread Mike Frysinger
On Tuesday 19 June 2007, Paulo Marques wrote: > The only in-kernel user of "memmem" is scripts/kallsyms.c and it only > uses it to find tokens that are 2 bytes in size. It is trivial to > replace it with a simple function that finds 2-byte tokens. > > This should help users from systems that don't