Re: [PATCH] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-25 Thread Aaron Tomlin
> If you assert with VM_BUG_ON, it will be active on debugging kernels > only, which I believe is better suited for a hotpath. Agreed. Regards, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-22 Thread Glauber Costa
On 02/22/2013 02:07 AM, Aaron Tomlin wrote: > The addition of this BUG_ON should make debugging easier. > While I understand that this code path is "hot", surely > it is better to assert the condition than to wait until > some random NULL pointer dereference or page fault. If the > caller passes an