On 02/22/2013 02:07 AM, Aaron Tomlin wrote: > The addition of this BUG_ON should make debugging easier. > While I understand that this code path is "hot", surely > it is better to assert the condition than to wait until > some random NULL pointer dereference or page fault. If the > caller passes an invalid nodeid, at this stage in my opinion > it's already a BUG. If you assert with VM_BUG_ON, it will be active on debugging kernels only, which I believe is better suited for a hotpath.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/