Re: [PATCH] fix typo in per_cpu_offset

2007-11-06 Thread Luming Yu
NAK for now. I'm trying to add lockdep , so please don't delete it until it could be proved really useless... Please don't hurry... On 11/7/07, Simon Horman <[EMAIL PROTECTED]> wrote: > On Tue, Oct 30, 2007 at 05:50:56PM +0900, Simon Horman wrote: > > On Tue, Oct 30, 2007 at 12:36:22AM -0700, Dav

Re: [PATCH] fix typo in per_cpu_offset

2007-11-06 Thread Simon Horman
On Tue, Oct 30, 2007 at 05:50:56PM +0900, Simon Horman wrote: > On Tue, Oct 30, 2007 at 12:36:22AM -0700, David Miller wrote: > > From: Simon Horman <[EMAIL PROTECTED]> > > Date: Tue, 30 Oct 2007 16:15:13 +0900 > > > > > Though curiuously with my config nothing uses per_cpu_offset() > > > (I added

Re: [PATCH] fix typo in per_cpu_offset

2007-10-30 Thread Simon Horman
On Tue, Oct 30, 2007 at 12:36:22AM -0700, David Miller wrote: > From: Simon Horman <[EMAIL PROTECTED]> > Date: Tue, 30 Oct 2007 16:15:13 +0900 > > > Though curiuously with my config nothing uses per_cpu_offset() > > (I added a bogus call to produce an error.) Is it actually > > used on ia64? > >

Re: [PATCH] fix typo in per_cpu_offset

2007-10-29 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 16:15:13 +0900 > Though curiuously with my config nothing uses per_cpu_offset() > (I added a bogus call to produce an error.) Is it actually > used on ia64? It is unused, and in that regard should probably be deleted. include/asm-gene

Re: [PATCH] fix typo in per_cpu_offset

2007-10-29 Thread Simon Horman
On Tue, Oct 23, 2007 at 03:15:55PM +0800, Luming Yu wrote: > Hello list, > > there is a typo in the definition of per_cpu_offset because, for ia64, > the __per_cpu_offset is an array. > > extern unsigned long __per_cpu_offset[NR_CPUS]; > -#define per_cpu_offset(x) (__per_cpu_offset(x)) > +#defin