On Tue, Oct 30, 2007 at 05:50:56PM +0900, Simon Horman wrote: > On Tue, Oct 30, 2007 at 12:36:22AM -0700, David Miller wrote: > > From: Simon Horman <[EMAIL PROTECTED]> > > Date: Tue, 30 Oct 2007 16:15:13 +0900 > > > > > Though curiuously with my config nothing uses per_cpu_offset() > > > (I added a bogus call to produce an error.) Is it actually > > > used on ia64? > > > > It is unused, and in that regard should probably be deleted. > > > > include/asm-generic/percpu.h defines a seemingly similarly > > unused per_cpu_offset() macro define as well > > It looks like they were both added by "[PATCH] lockdep: add per_cpu_offset()" > (a875a69f8b00a38b4f40d9632a4fc71a159f0e0d) > > Perhaps they were used at that time?
I looked into this a little further: I'm pretty much convinced that the asm-ia64 version of per_cpu_offset() is unused as ia64 doesn't have lockdep. I will send a patch to get rid of it. The generic version might be used on mips, sh or arm with CONFIG_SMP, as these architectures have lockdep. I did managed to produce a compiler error on mips by removing the asm-generic version of per_cpu_offset(). -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
