Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-30 Thread Rafael J. Wysocki
On Wednesday, April 30, 2014 09:34:03 AM Viresh Kumar wrote: > On 30 April 2014 04:09, Rafael J. Wysocki wrote: > > It should be cleaned up generally, so if you have the time and you're > > willing > > to do such things, please do them. > > > > That said things like lines in excess of 80 characte

Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-29 Thread Viresh Kumar
On 30 April 2014 04:09, Rafael J. Wysocki wrote: > It should be cleaned up generally, so if you have the time and you're willing > to do such things, please do them. > > That said things like lines in excess of 80 characters may stay as they are. I have tried this sort of stuff earlier, but there

Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-29 Thread Rafael J. Wysocki
On Wednesday, April 23, 2014 04:53:36 PM Stratos Karafotis wrote: > On 23/04/2014 01:37 μμ, Rafael J. Wysocki wrote: > > On Wednesday, April 23, 2014 12:13:54 AM Stratos Karafotis wrote: > >> Fix the following checkpatch warnings: > > > > In addition to comments from Viresh, I have a general one.

Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-23 Thread Stratos Karafotis
On 23/04/2014 07:46 πμ, Viresh Kumar wrote: > On 23 April 2014 02:43, Stratos Karafotis wrote: >> @@ -342,7 +333,7 @@ static int core_voltage_pre_transition(struct >> powernow_k8_data *data, >> return 1; >> >> if (savefid != data->currfid) { >> - printk(KERN_

Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-23 Thread Stratos Karafotis
On 23/04/2014 01:37 μμ, Rafael J. Wysocki wrote: > On Wednesday, April 23, 2014 12:13:54 AM Stratos Karafotis wrote: >> Fix the following checkpatch warnings: > > In addition to comments from Viresh, I have a general one. > > Some of the checkpatch.pl warnings are not worth fixing at all -> > >>

Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-23 Thread Rafael J. Wysocki
On Wednesday, April 23, 2014 12:13:54 AM Stratos Karafotis wrote: > Fix the following checkpatch warnings: In addition to comments from Viresh, I have a general one. Some of the checkpatch.pl warnings are not worth fixing at all -> > - WARNING: Prefer pr_err(... to printk(KERN_ERR ... > - WARNIN

Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

2014-04-22 Thread Viresh Kumar
On 23 April 2014 02:43, Stratos Karafotis wrote: > @@ -342,7 +333,7 @@ static int core_voltage_pre_transition(struct > powernow_k8_data *data, > return 1; > > if (savefid != data->currfid) { > - printk(KERN_ERR PFX "ph1 err, currfid changed 0x%x\n", > +