Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-20 Thread Rafael J. Wysocki
On Wed, Mar 16, 2016 at 5:52 AM, Viresh Kumar wrote: > On 16-03-16, 01:51, Rafael J. Wysocki wrote: >> OK, so the problem with doing that in syscore ops is that the I2C bus >> needed for it may not be available at that point, which is fair >> enough. > > Not just that. We wouldn't call syscore-ops

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-19 Thread Viresh Kumar
On 16-03-16, 14:12, Rafael J. Wysocki wrote: > No, it won't. This might be applicable to other governors, but not to > "performance" (look at what it does on _START instead of just > guessing). > > > So, your patch break things for sure. > > I'm not actually sure it breaks anything. > > Theoret

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-19 Thread Viresh Kumar
On 16-03-16, 13:29, Rafael J. Wysocki wrote: > On Wed, Mar 16, 2016 at 5:52 AM, Viresh Kumar wrote: > > Not just that. We wouldn't call syscore-ops for the boot-cpu. It never went > > away. > > Yes, we would. > > We actually call syscore ops *only* on that CPU. Ahh, I thought you are talking ab

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-18 Thread Rafael J. Wysocki
On Wed, Mar 16, 2016 at 5:47 AM, Viresh Kumar wrote: > On 15-03-16, 13:11, Rafael J. Wysocki wrote: >> On Tue, Mar 15, 2016 at 7:10 AM, Viresh Kumar >> wrote: >> > On 12-03-16, 03:05, Rafael J. Wysocki wrote: >> >> From: Rafael J. Wysocki >> >> >> >> cpufreq_resume() attempts to resync the curr

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-15 Thread Viresh Kumar
On 16-03-16, 01:51, Rafael J. Wysocki wrote: > OK, so the problem with doing that in syscore ops is that the I2C bus > needed for it may not be available at that point, which is fair > enough. Not just that. We wouldn't call syscore-ops for the boot-cpu. It never went away. > Still, though, the w

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-15 Thread Viresh Kumar
On 15-03-16, 13:11, Rafael J. Wysocki wrote: > On Tue, Mar 15, 2016 at 7:10 AM, Viresh Kumar wrote: > > On 12-03-16, 03:05, Rafael J. Wysocki wrote: > >> From: Rafael J. Wysocki > >> > >> cpufreq_resume() attempts to resync the current frequency with > >> policy->cur for the first online CPU, but

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-15 Thread Rafael J. Wysocki
On Tue, Mar 15, 2016 at 1:11 PM, Rafael J. Wysocki wrote: > On Tue, Mar 15, 2016 at 7:10 AM, Viresh Kumar wrote: >> On 12-03-16, 03:05, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> cpufreq_resume() attempts to resync the current frequency with >>> policy->cur for the first online

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-15 Thread Rafael J. Wysocki
On Tue, Mar 15, 2016 at 7:10 AM, Viresh Kumar wrote: > On 12-03-16, 03:05, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> cpufreq_resume() attempts to resync the current frequency with >> policy->cur for the first online CPU, but first it does that after >> restarting governors for all

Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

2016-03-14 Thread Viresh Kumar
On 12-03-16, 03:05, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > cpufreq_resume() attempts to resync the current frequency with > policy->cur for the first online CPU, but first it does that after > restarting governors for all active policies (which means that this > is racy with respe