Re: [PATCH] Fix direct mapping correctly in ioremap

2008-02-14 Thread Andi Kleen
On Thu, Feb 14, 2008 at 05:03:23PM +0100, Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > - if (ioremap_change_attr(vaddr, size, mode) < 0) { > > + /* Fix up the direct mapping for the new cache attributes */ > > + err = ioremap_change_attr((unsigned long)__va(phys_addr

Re: [PATCH] Fix direct mapping correctly in ioremap

2008-02-14 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > - if (ioremap_change_attr(vaddr, size, mode) < 0) { > + /* Fix up the direct mapping for the new cache attributes */ > + err = ioremap_change_attr((unsigned long)__va(phys_addr), > + size + offset, mode); Ugh. This