Re: [PATCH] ASoC: wm_hubs: Fix DC Servo readback

2014-08-13 Thread Mark Brown
On Wed, Aug 13, 2014 at 01:16:37PM +0100, Charles Keepax wrote: > On Wed, Aug 13, 2014 at 12:38:41PM +0100, Mark Brown wrote: > > On Wed, Aug 13, 2014 at 12:08:44PM +0100, Charles Keepax wrote: > > > Also I think the situation is more complex for example on version > > > 4.4 of the datasheet for w

Re: [PATCH] ASoC: wm_hubs: Fix DC Servo readback

2014-08-13 Thread Charles Keepax
On Wed, Aug 13, 2014 at 01:16:37PM +0100, Charles Keepax wrote: > On Wed, Aug 13, 2014 at 12:38:41PM +0100, Mark Brown wrote: > > On Wed, Aug 13, 2014 at 12:08:44PM +0100, Charles Keepax wrote: > > > On Wed, Aug 13, 2014 at 11:47:20AM +0100, Nikesh Oswal wrote: > > > > > > case 2: > > > >

Re: [PATCH] ASoC: wm_hubs: Fix DC Servo readback

2014-08-13 Thread Charles Keepax
On Wed, Aug 13, 2014 at 12:38:41PM +0100, Mark Brown wrote: > On Wed, Aug 13, 2014 at 12:08:44PM +0100, Charles Keepax wrote: > > On Wed, Aug 13, 2014 at 11:47:20AM +0100, Nikesh Oswal wrote: > > > > case 2: > > > dcs_reg = WM8994_DC_SERVO_4E; > > > break; > > > - case 1: > >

Re: [PATCH] ASoC: wm_hubs: Fix DC Servo readback

2014-08-13 Thread Mark Brown
On Wed, Aug 13, 2014 at 12:08:44PM +0100, Charles Keepax wrote: > On Wed, Aug 13, 2014 at 11:47:20AM +0100, Nikesh Oswal wrote: > > case 2: > > dcs_reg = WM8994_DC_SERVO_4E; > > break; > > - case 1: > > - dcs_reg = WM8994_DC_SERVO_READBACK; > > - b

Re: [PATCH] ASoC: wm_hubs: Fix DC Servo readback

2014-08-13 Thread Charles Keepax
On Wed, Aug 13, 2014 at 11:47:20AM +0100, Nikesh Oswal wrote: > wm_hubs is a common driver code shared by WM8958, WM1811, WM8944 > and WM8993 all these codecs have the DC Servo Values either in register > 57h or 59h. Current code was reading register 58h for WM8958 and WM8994 > revisions 2 and 3 bu