Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-22 Thread Mark Brown
On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: > Make generic ASoC AC'97 CODEC selectable in config. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Mark Brown
On Thu, May 14, 2015 at 09:38:55PM +0200, Lars-Peter Clausen wrote: > select forces a symbol on regardless of whether its dependencies are met or > not. But for any symbol that is on, no matter whether it was manually > selected or selected by a 'select' from another symbol, any symbols selected >

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 09:28 PM, Mark Brown wrote: On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote: On 05/14/2015 09:10 PM, Mark Brown wrote: Does the select from SND_SOC_AC97_BUS actually happen if it is selected by SND_SOC_ALL_CODECS? That's the issue, if it works now it's a rela

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Mark Brown
On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote: > On 05/14/2015 09:10 PM, Mark Brown wrote: > >Does the select from SND_SOC_AC97_BUS actually happen if it is selected > >by SND_SOC_ALL_CODECS? That's the issue, if it works now it's a > >relatively recent thing. > I'm not sure

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 09:10 PM, Mark Brown wrote: On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote: On 05/14/2015 07:53 PM, Mark Brown wrote: select doesn't respect dependencies, it'll just force on the selected symbol. The patch works fine, neither SND_SOC_AC97_BUS nor the symbo

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Mark Brown
On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote: > On 05/14/2015 07:53 PM, Mark Brown wrote: > >select doesn't respect dependencies, it'll just force on the selected > >symbol. > The patch works fine, neither SND_SOC_AC97_BUS nor the symbols selected by > SND_SOC_AC97_BUS have

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Lars-Peter Clausen
On 05/14/2015 07:53 PM, Mark Brown wrote: On Wed, May 13, 2015 at 10:57:24PM +0200, Maciej S. Szmigiero wrote: W dniu 12.05.2015 19:58, Mark Brown pisze: On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_88

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-14 Thread Mark Brown
On Wed, May 13, 2015 at 10:57:24PM +0200, Maciej S. Szmigiero wrote: > W dniu 12.05.2015 19:58, Mark Brown pisze: > > On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: > >> @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS > >>select SND_SOC_88PM860X if MFD_88PM860X > >>select

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-13 Thread Maciej S. Szmigiero
Thanks for looking into the patch. W dniu 12.05.2015 19:58, Mark Brown pisze: > On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: > >> @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS >> select SND_SOC_88PM860X if MFD_88PM860X >> select SND_SOC_L3 >> select SND_SOC_AB

Re: [PATCH] ASoC: codecs-ac97: make selectable in config

2015-05-12 Thread Mark Brown
On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote: > @@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS > select SND_SOC_88PM860X if MFD_88PM860X > select SND_SOC_L3 > select SND_SOC_AB8500_CODEC if ABX500_CORE > - select SND_SOC_AC97_CODEC if SND_SOC_AC97_BUS > +