On 05/14/2015 07:53 PM, Mark Brown wrote:
On Wed, May 13, 2015 at 10:57:24PM +0200, Maciej S. Szmigiero wrote:
W dniu 12.05.2015 19:58, Mark Brown pisze:
On Sun, May 10, 2015 at 12:12:04AM +0200, Maciej S. Szmigiero wrote:
@@ -16,7 +16,7 @@ config SND_SOC_ALL_CODECS
select SND_SOC_88PM860X if MFD_88PM860X
select SND_SOC_L3
select SND_SOC_AB8500_CODEC if ABX500_CORE
- select SND_SOC_AC97_CODEC if SND_SOC_AC97_BUS
+ select SND_SOC_AC97_CODEC
select SND_SOC_AD1836 if SPI_MASTER
select SND_SOC_AD193X_SPI if SPI_MASTER
select SND_SOC_AD193X_I2C if I2C
No, you're missing the point of what _ALL_CODECS does - it builds
everything possible. This will break the build for systems without
AC'97 support.
How?
In the second hunk of the patch I've made SND_SOC_AC97_CODEC select
SND_SOC_AC97_BUS.
select doesn't respect dependencies, it'll just force on the selected
symbol.
The patch works fine, neither SND_SOC_AC97_BUS nor the symbols selected by
SND_SOC_AC97_BUS have any dependencies.
Although one might argue that only AC97 host driver should select
SND_SOC_AC97_BUS and the CODEC drivers should depend on it.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
