Re: memcpy_fromio in dmi_scan.c

2013-07-08 Thread Jean Delvare
Hi Andrew, Sorry for the late reply. Le Thursday 25 April 2013 à 13:37 -0700, Andrew Morton a écrit : > So what's the fix? This? > > --- a/drivers/firmware/dmi_scan.c~a > +++ a/drivers/firmware/dmi_scan.c > @@ -500,9 +500,12 @@ void __init dmi_scan_machine(void) > goto err

Re: memcpy_fromio in dmi_scan.c

2013-04-25 Thread Andrew Morton
On Thu, 25 Apr 2013 04:52:42 -0500 Robin Holt wrote: > On Wed, Apr 24, 2013 at 09:07:24PM -0500, Robin Holt wrote: > > On Wed, Apr 24, 2013 at 08:16:50PM +, Luck, Tony wrote: > > > > That being said, "my" SN2 machine was previously running kernel 3.0.34 > > > > which has the old dmi_scan code

Re: memcpy_fromio in dmi_scan.c

2013-04-25 Thread Robin Holt
On Wed, Apr 24, 2013 at 09:22:08PM +0200, Jean Delvare wrote: > Hi Tony, > > Thanks for stepping in. > > Le Tuesday 23 April 2013 à 22:00 +, Luck, Tony a écrit : > > > I don't have much knowledge about IA64 either. All I see is that while > > > x86 implements memcpy_fromio() with memcpy [1],

Re: memcpy_fromio in dmi_scan.c

2013-04-25 Thread Robin Holt
On Wed, Apr 24, 2013 at 09:07:24PM -0500, Robin Holt wrote: > On Wed, Apr 24, 2013 at 08:16:50PM +, Luck, Tony wrote: > > > That being said, "my" SN2 machine was previously running kernel 3.0.34 > > > which has the old dmi_scan code and it also said "DMI not present or > > > invalid." Plus dmid

Re: memcpy_fromio in dmi_scan.c

2013-04-24 Thread Robin Holt
On Wed, Apr 24, 2013 at 08:16:50PM +, Luck, Tony wrote: > > That being said, "my" SN2 machine was previously running kernel 3.0.34 > > which has the old dmi_scan code and it also said "DMI not present or > > invalid." Plus dmidecode fails on this machine with: > > > > /sys/firmware/efi/systab:

Re: memcpy_fromio in dmi_scan.c

2013-04-24 Thread Zhenzhong Duan
On 2013-04-25 03:22, Jean Delvare wrote: What is strange is that the call to memcpy_fromio was added a long time ago, long before dmi_scan was enabled on ia64. I think memcpy_fromio is used to copy bios data to a mem buffer to speed up read access. zduan -- To unsubscribe from this list: se

RE: memcpy_fromio in dmi_scan.c

2013-04-24 Thread Luck, Tony
> That being said, "my" SN2 machine was previously running kernel 3.0.34 > which has the old dmi_scan code and it also said "DMI not present or > invalid." Plus dmidecode fails on this machine with: > > /sys/firmware/efi/systab: SMBIOS entry point missing > > So it might as well be that DMI support

RE: memcpy_fromio in dmi_scan.c

2013-04-24 Thread Jean Delvare
Hi Tony, Thanks for stepping in. Le Tuesday 23 April 2013 à 22:00 +, Luck, Tony a écrit : > > I don't have much knowledge about IA64 either. All I see is that while > > x86 implements memcpy_fromio() with memcpy [1], ia64 implements it with > > readb [2]. There must be a reason for that, and

RE: memcpy_fromio in dmi_scan.c

2013-04-23 Thread Luck, Tony
> I don't have much knowledge about IA64 either. All I see is that while > x86 implements memcpy_fromio() with memcpy [1], ia64 implements it with > readb [2]. There must be a reason for that, and I can only suppose that > memcpy on __iomem pointers doesn't work on IA64. If memcpy doesn't work > th

Re: memcpy_fromio in dmi_scan.c

2013-04-23 Thread Jean Delvare
Le Tuesday 23 April 2013 à 11:25 +0800, DuanZhenzhong a écrit : > Jean Delvare wrote: > > Hi Duan, Andrew, > > > > I am looking at the following commit: > > > > commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 > > Author: Zhenzhong Duan > > Date: Thu Dec 20 15:05:14 2012 -0800 > > > > drivers

Re: memcpy_fromio in dmi_scan.c

2013-04-22 Thread DuanZhenzhong
Jean Delvare wrote: Hi Duan, Andrew, I am looking at the following commit: commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 Author: Zhenzhong Duan Date: Thu Dec 20 15:05:14 2012 -0800 drivers/firmware/dmi_scan.c: fetch dmi version from SMBIOS if it exists And I am worried about calls to