Le Tuesday 23 April 2013 à 11:25 +0800, DuanZhenzhong a écrit : > Jean Delvare wrote: > > Hi Duan, Andrew, > > > > I am looking at the following commit: > > > > commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377 > > Author: Zhenzhong Duan <zhenzhong.d...@oracle.com> > > Date: Thu Dec 20 15:05:14 2012 -0800 > > > > drivers/firmware/dmi_scan.c: fetch dmi version from SMBIOS if it exists > > > > And I am worried about calls to memcpy_fromio(), or lack thereof. Before > > this commit, the code would take great care to always call > > memcpy_fromio() to get data from the 0xF0000-0xFFFFF memory range (BIOS > > data) and operate on that copy. After this commit, the code is happily > > calling memcmp() directly on an __iomem pointer. It seems to be harmless > > on x86, but it will break on IA64, won't it? > > > > > Hi Jean, > What's the impact of reading bios data directly on IA64? > Sorry I have little knowledge about IA64.
I don't have much knowledge about IA64 either. All I see is that while x86 implements memcpy_fromio() with memcpy [1], ia64 implements it with readb [2]. There must be a reason for that, and I can only suppose that memcpy on __iomem pointers doesn't work on IA64. If memcpy doesn't work then I can't see memcmp working. [1] http://lxr.linux.no/#linux+v3.8.8/arch/x86/include/asm/io.h#L209 [2] http://lxr.linux.no/#linux+v3.8.8/arch/ia64/lib/io.c#L10 Tony, Fenghua? Did anyone test DMI support on IA64 in kernel 3.8.0+, 3.4.28+, 3.2.38+ or 3.061+? -- Jean Delvare Suse L3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
