Hi,
> > > > + ret = devm_watchdog_register_device(&client->dev, &ds1374->wdt);
> > > > if (ret) {
> > > > - misc_deregister(&ds1374_miscdev);
> > > > + dev_err(&client->dev, "failed to register DS1374
> > > > watchdog
> > > > +device\n");
>
> There was n
On 06/07/2020 05:18:39+, Johnson CH Chen (陳昭勳) wrote:
> > > #endif /*CONFIG_RTC_DRV_DS1374_WDT*/
> > > /*
> > > @@ -653,15 +514,25 @@ static int ds1374_probe(struct i2c_client
> > > *client,
> > >
> > > #ifdef CONFIG_RTC_DRV_DS1374_WDT
> > > save_client = client;
> > > - ret = misc_registe
Hi,
Thanks for your good suggestions!
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index
> > b54d87d45c89..5e2444af5657 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -282,6 +282,7 @@ config RTC_DRV_DS1374 config
> RTC_DRV_DS1374_WDT
> > bool "Dallas/
On Fri, Jul 03, 2020 at 11:48:09AM +, Johnson CH Chen (陳昭勳) wrote:
> Let ds1374 watchdog use watchdog core functions. It also includes
> improving watchdog timer setting and nowayout, and just uses ioctl()
> of watchdog core.
>
> Signed-off-by: Johnson Chen
> Reported-by: kernel test robot
>
Hi "Johnson,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on linux/master linus/master v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to
5 matches
Mail list logo
