RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> Subject: Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state > > On Sat, Oct 08, 2016 at 04:56:39PM +, Winkler, Tomas wrote: > > > > > > > > On Sat, Oct 08, 2016 at 02:27:06PM +, Winkler, Tomas wrote: > > > > > > >

Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Jarkko Sakkinen
On Sat, Oct 08, 2016 at 10:42:03AM -0600, Jason Gunthorpe wrote: > On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > > > Rather you it would be better not to use cmdReady/goIdle at all if > > kernel is not compiled with CONFIG_PM. > > It would be best practice to ensure the tpm i

Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Jarkko Sakkinen
On Sat, Oct 08, 2016 at 04:56:39PM +, Winkler, Tomas wrote: > > > > > On Sat, Oct 08, 2016 at 02:27:06PM +, Winkler, Tomas wrote: > > > > > > > > On Sat, Oct 08, 2016 at 02:59:37PM +0300, Tomas Winkler wrote: > > > > > From: "Winkler, Tomas" > > > > > > > > > > There is a HW bug in Skyla

RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > > > Rather you it would be better not to use cmdReady/goIdle at all if > > kernel is not compiled with CONFIG_PM. > > It would be best practice to ensure the tpm is powered up no matter how the > kernel is compiled.. The firmwa

RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> > On Sat, Oct 08, 2016 at 02:27:06PM +, Winkler, Tomas wrote: > > > > > > On Sat, Oct 08, 2016 at 02:59:37PM +0300, Tomas Winkler wrote: > > > > From: "Winkler, Tomas" > > > > > > > > There is a HW bug in Skylake, Kabylake, and Broxton PCH Intel PTT > > > > device, where most of the regist

Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Jason Gunthorpe
On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote: > Rather you it would be better not to use cmdReady/goIdle at all if > kernel is not compiled with CONFIG_PM. It would be best practice to ensure the tpm is powered up no matter how the kernel is compiled.. The firmware may have lef

Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Jarkko Sakkinen
On Sat, Oct 08, 2016 at 02:27:06PM +, Winkler, Tomas wrote: > > > > On Sat, Oct 08, 2016 at 02:59:37PM +0300, Tomas Winkler wrote: > > > From: "Winkler, Tomas" > > > > > > There is a HW bug in Skylake, Kabylake, and Broxton PCH Intel PTT > > > device, where most of the registers in the contro

RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Winkler, Tomas
> > On Sat, Oct 08, 2016 at 02:59:37PM +0300, Tomas Winkler wrote: > > From: "Winkler, Tomas" > > > > There is a HW bug in Skylake, Kabylake, and Broxton PCH Intel PTT > > device, where most of the registers in the control area except START, > > REQUEST, CANCEL, and LOC_CTRL lost retention when t

Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state

2016-10-08 Thread Jarkko Sakkinen
On Sat, Oct 08, 2016 at 02:59:37PM +0300, Tomas Winkler wrote: > From: "Winkler, Tomas" > > There is a HW bug in Skylake, Kabylake, and Broxton PCH Intel PTT device, > where most of the registers in the control area except START, REQUEST, > CANCEL, and LOC_CTRL lost retention when the device is i