RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-15 Thread Nguyen, Tom L
Tuesday, March 15, 2005 2:51 PM Linas Vepstas wrote: >> +void hw_aer_unregister(void) >> +{ >> +struct pci_dev *dev = (struct pci_dev*)host->dev; >> +unsigned short id; >> + >> +id = (dev->bus->number << 8) | dev->devfn; >> + >> +/* Unregister with AER Root driver */ >> +pci

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-15 Thread Grant Grundler
On Tue, Mar 15, 2005 at 04:51:01PM -0600, Linas Vepstas wrote: > Hi, > > On Fri, Mar 11, 2005 at 04:12:18PM -0800, long was heard to remark: > > > +void hw_aer_unregister(void) > > +{ > > + struct pci_dev *dev = (struct pci_dev*)host->dev; I'm more nervous about "host" being defined as a globa

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-15 Thread Linas Vepstas
Hi, On Fri, Mar 11, 2005 at 04:12:18PM -0800, long was heard to remark: > +void hw_aer_unregister(void) > +{ > + struct pci_dev *dev = (struct pci_dev*)host->dev; > + unsigned short id; > + > + id = (dev->bus->number << 8) | dev->devfn; > + > + /* Unregister with AER Root dri

RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-14 Thread Nguyen, Tom L
On Saturday, March 12, 2005 1:38 AM Andi Kleen wrote: >I haven't read your code in detail, just a high level remark. > >> +6. Enabling AER Aware Support in PCI Express Device Driver >> + >> +To enable AER aware support requires a software driver to configure >> +the AER capability structure within

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-14 Thread Randy.Dunlap
Nguyen, Tom L wrote: Monday, March 14, 2005 3:01 AM David Vrabel wrote: This patch includes PCIEAER-HOWTO.txt, which describes how the PCI Express Advanced Error Reporting Root driver works. --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt Could this be placed in a sub-system subdirectory (cre

RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-14 Thread Nguyen, Tom L
Monday, March 14, 2005 3:01 AM David Vrabel wrote: >> This patch includes PCIEAER-HOWTO.txt, which describes how the PCI >> Express Advanced Error Reporting Root driver works. >> >> --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt >> >Could this be placed in a sub-system subdirectory (creating

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-14 Thread David Vrabel
long wrote: > This patch includes PCIEAER-HOWTO.txt, which describes how the PCI > Express Advanced Error Reporting Root driver works. > --- linux-2.6.11-rc5/Documentation/PCIEAER-HOWTO.txt Could this be placed in a sub-system subdirectory (creating one if necessary, e.g., pci/)? The root of Doc

Re: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

2005-03-12 Thread Andi Kleen
long <[EMAIL PROTECTED]> writes: I haven't read your code in detail, just a high level remark. > +6. Enabling AER Aware Support in PCI Express Device Driver > + > +To enable AER aware support requires a software driver to configure > +the AER capability structure within its device, to initialize