On Saturday, March 12, 2005 1:38 AM Andi Kleen wrote: >I haven't read your code in detail, just a high level remark. > >> +6. Enabling AER Aware Support in PCI Express Device Driver >> + >> +To enable AER aware support requires a software driver to configure >> +the AER capability structure within its device, to initialize its AER >> +aware callback handle and to call pcie_aer_register. Sections 6.1, >> +6.2, and 6.3 describe how to enable AER aware support in details. > >There is currently discussion underway for a generic portable PCI >error reporting interface for drivers. This is already being worked >on by some PPC64 and IA64 people. I don't think it would be a good idea >to add another incompatible PCI-E specific interface. > >So I would recommend to not apply pcie_aer_register() et.al. >and coordinate with the others working on this area on a common >interface. > >This would only impact the device driver interface; having >a PCI Express specific interface in sysfs is probably ok. > >Otherwise we would end up with tons of ifdefs in the drivers >supporting multiple error reporting interfaces for different platforms,
>which would be bad. > >Also in general I think the necessary callbacks should >be part of the basic device; not provided in a separate structure. Agree. We will coordinate with the others working on this area on a common interface. Thanks for your suggestions, Long - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
