> > > +int lp3943_read_byte(struct lp3943 *l, u8 reg, u8 *read)
> >
> > Not sure I like 'l' as a variable name. The function is small enough
> > to get away with it in this context, but it would probably be better
> > if it were renamed to something more meaningful.
>
> LP3943 consists of two dev
> This needs to be reviewed by the devicetree people.
> Please break out the bindings separately and include
> devicet...@vger.kernel.org on that review.
OK, thanks.
> > +++ b/Documentation/devicetree/bindings/mfd/lp3943.txt
> > @@ -0,0 +1,23 @@
> > +Bindings for TI/National Semiconductor LP3943
Hi Lee,
Thanks for your detailed review.
> > diff --git a/Documentation/devicetree/bindings/mfd/lp3943.txt
> b/Documentation/devicetree/bindings/mfd/lp3943.txt
> > new file mode 100644
> > index 000..4eb251d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/lp3943.txt
> > @@ -0
On Tue, Jul 16, 2013 at 4:38 AM, Kim, Milo wrote:
This needs to be reviewed by the devicetree people.
Please break out the bindings separately and include
devicet...@vger.kernel.org on that review.
> +++ b/Documentation/devicetree/bindings/mfd/lp3943.txt
> @@ -0,0 +1,23 @@
> +Bindings for TI/Nat
This driver is heavily regmap based, so I think it would make sense
for Mark Brown to glance over it briefly.
> LP3943 has 16 output LED channels which can be used as GPIO expander and
> PWM generators.
> This patch supports the MFD structure of those features.
>
> * Regmap I2C interface for R/W
5 matches
Mail list logo
