> This needs to be reviewed by the devicetree people. > Please break out the bindings separately and include > devicet...@vger.kernel.org on that review.
OK, thanks. > > +++ b/Documentation/devicetree/bindings/mfd/lp3943.txt > > @@ -0,0 +1,23 @@ > > +Bindings for TI/National Semiconductor LP3943 Driver > > + > > +Required properties: > > + - compatible: "ti,lp3943" > > + - reg: 7bit I2C slave address. 0x60 ~ 0x67 > > + > > +Optional properties: > > + - ti,pwm0, ti,pwm1: Output channel definition for PWM port 0 and 1 > > + 0 = invalid, 1 = LED0, 2 = LED 1, ... 16 = > > +LED15 > > + > > +Datasheet > > + http://www.ti.com/lit/ds/snvs256b/snvs256b.pdf > > + > > +Application note: How to use LP3943 as a GPIO expander and PWM > > +generator > > + http://www.ti.com/lit/an/snva287a/snva287a.pdf > > Do we usually put these things into bindings? Actually I want to put this information in the driver document, but I've not found which part is the best place for the MFD documentation. > > +Example: > > + > > + lp3943@60 { > > + compatible = "ti,lp3943"; > > + reg = <0x60>; > > + pwm1 = /bits/ 8 <2>; /* use LED1 output as PWM #1 */ > > + }; > > OK so there is a way to state which lines are used for PWM. > > I think you should also specify which lines are used for GPIO, and which > lines are used for LEDs. > > And I'd like the masks to be passed to each subdriver, so we can avoid the > scenario where one and the same line gets used for GPIO, LED and PWM at the > same time. Good idea. This is my missing point - I was writing the LP3943 DT is only used for the definition of the platform data. Thanks. Regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
