Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 15:27, Dragos Tatulea wrote: > > On Mon, 2024-07-08 at 14:55 +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device > > > > Si

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Tue, 9 Jul 2024 at 12:56, Ratheesh Kannoth wrote: > > On 2024-07-08 at 12:25:49, Cindy Lu (l...@redhat.com) wrote: > > +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev, > > + struct vdpa_device *dev, > > + const struct v

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 19:26, Michael S. Tsirkin wrote: > > On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-09 Thread Cindy Lu
On Mon, 8 Jul 2024 at 15:03, Jason Wang wrote: > > On Mon, Jul 8, 2024 at 2:56 PM Cindy Lu wrote: > > > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device > > Great. >

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Ratheesh Kannoth
On 2024-07-08 at 12:25:49, Cindy Lu (l...@redhat.com) wrote: > +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev, > + struct vdpa_device *dev, > + const struct vdpa_dev_set_config *add_config) > +{ > + struct mlx5_vdpa_de

RE: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Parav Pandit
el@vger.kernel.org; k...@vger.kernel.org > Subject: Re: [PATCH] vdpa/mlx5: Add the support of set mac address > > On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use ml

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Andrew Lunn
On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote: > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device > > Signed-off-by: Cindy Lu > --- > drivers/vdpa/mlx5/net/mlx5_vn

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Michael S. Tsirkin
On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote: > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device > > Signed-off-by: Cindy Lu Is this on top of your other patchset

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Dragos Tatulea
On Mon, 2024-07-08 at 14:55 +0800, Cindy Lu wrote: > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device > > Signed-off-by: Cindy Lu > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c |

Re: [PATCH] vdpa/mlx5: Add the support of set mac address

2024-07-08 Thread Jason Wang
On Mon, Jul 8, 2024 at 2:56 PM Cindy Lu wrote: > > Add the function to support setting the MAC address. > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > to set the mac address > > Tested in ConnectX-6 Dx device Great. > > Signed-off-by: Cindy Lu I guess this should be part of the ser