Re: [PATCH] reset: Add driver for dispmix reset

2019-08-15 Thread Philipp Zabel
Hi Fancy, On Wed, 2019-06-26 at 06:46 +, Fancy Fang wrote: > Hi Philipp, > > Thanks for your comments. And please see my answers below. > [...] > > +Specifying sft-rstn control of devices > > +== > > + > > +Device nodes in Display Mix should specify the r

Re: [PATCH] reset: Add driver for dispmix reset

2019-06-27 Thread Philipp Zabel
On Wed, 2019-06-26 at 06:46 +, Fancy Fang wrote: [...] > > The same goes for the clock soft enable bits on i.MX8MM. If those > > bits actually control clock gates, they should not be described as > > reset controls in the device tree. > > [FF] Make sense. The functions provided by the "dispmi

RE: [PATCH] reset: Add driver for dispmix reset

2019-06-25 Thread Fancy Fang
...@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx Subject: Re: [PATCH] reset: Add driver for dispmix reset Hi Fancy, thank you for the patch. I have a few questions below. On Tue, 2019-06-25 at 05:54 +, Fancy Fang wrote: > This is an reset driver to implement a reset controller dev

Re: [PATCH] reset: Add driver for dispmix reset

2019-06-25 Thread Philipp Zabel
Hi Fancy, thank you for the patch. I have a few questions below. On Tue, 2019-06-25 at 05:54 +, Fancy Fang wrote: > This is an reset driver to implement a reset controller > device DISPMIX on IMX8MM and IMX8MN platforms. Dispmix > reset is used to reset or enable related buses and clks > for