Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 2:01 AM Song Liu wrote: > > On Wed, Feb 5, 2025 at 6:55 PM Yafang Shao wrote: > [...] > > > I think we should first understand why the trampoline is not > > > freed. > > > > IIUC, the fexit works as follows, > > > > bpf_trampoline > > + __bpf_tramp_enter > >+

Re: [PATCHv3 net 0/2] bonding: fix incorrect mac address setting

2025-02-07 Thread Hangbin Liu
Please hold on this patch. Our QE reported that with bare NIC, the backup NIC can't receive the NS messages even after joining the multicast MAC group. But after remove the backup NIC from bond, the NIC interface could receive the NS message. This is weird, it looks the backup NIC dropped the NS m

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Sat, Feb 8, 2025 at 12:59 AM Josh Poimboeuf wrote: > > On Fri, Feb 07, 2025 at 11:16:45AM +0800, Yafang Shao wrote: > > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > > Why does this happen? > > > > It occurs during the KLP transition. It seems like the KLP transition > > is taking

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
oes look the livepatched FuncA here? > > > Does it contain changes only for Fix3? > > > Or is it cummulative livepatches_funA includes both Fix1 + Fix3? > > > > It is cumulative livepatches_funA includes both Fix1 + Fix3. > > It makes sense. > > I have missed th

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 7:01 PM Petr Mladek wrote: > > On Wed 2025-02-05 14:16:42, Yafang Shao wrote: > > On Tue, Feb 4, 2025 at 9:05 PM Petr Mladek wrote: > > > > > > On Mon 2025-02-03 17:44:52, Yafang Shao wrote: > > > > On Fri, Jan 31, 2025 at 9:18 PM Miroslav Benes wrote: > > > > > > > > > >

Re: [PATCH v2] vdpa/mlx5: Fix mlx5_vdpa_get_config() endianness on big-endian machines

2025-02-07 Thread Jason Wang
On Wed, Feb 5, 2025 at 2:16 AM Dragos Tatulea wrote: > > On 02/04, Konstantin Shkolnyy wrote: > > mlx5_vdpa_dev_add() doesn’t initialize mvdev->actual_features. It’s > > initialized later by mlx5_vdpa_set_driver_features(). However, > > mlx5_vdpa_get_config() depends on the VIRTIO_F_VERSION_1 flag

Re: [PATCH bpf-next] selftests/bpf: Remove with_addr.sh and with_tunnels.sh

2025-02-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau : On Tue, 04 Feb 2025 11:59:43 +0100 you wrote: > Those two scripts were used by test_flow_dissector.sh to setup/cleanup > the network topology before/after the tests. test_flow_dissector.sh > have been deleted by comm

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 5:36 PM Petr Mladek wrote: > > On Fri 2025-02-07 11:16:45, Yafang Shao wrote: > > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > > > - Temporary Loss of Patching > > > > > > > > During the repla

Re: [PATCH v2 bpf 1/2] bpf: skip non exist keys in generic_map_lookup_batch

2025-02-07 Thread Alexei Starovoitov
On Thu, Feb 6, 2025 at 9:45 PM Yan Zhai wrote: > > The generic_map_lookup_batch currently returns EINTR if it fails with > ENOENT and retries several times on bpf_map_copy_value. The next batch > would start from the same location, presuming it's a transient issue. > This is incorrect if a map can

Re: Re: Re: [PATCH 2/2] libbpf: BPF programs dynamic loading and attaching

2025-02-07 Thread Martin Kelly
On Wed, 2025-02-05 at 14:33 -0800, Andrii Nakryiko wrote: > > > > > > > > I see two ways forward for you. Either you can break apart your > > > > BPF > > > > object of ~100 BPF programs into more independent BPF objects > > > > > > (seeing > > > > that programs can be independently loaded/unloaded

Re: [PATCH v2 bpf 2/2] selftests: bpf: test batch lookup on array of maps with holes

2025-02-07 Thread Hou Tao
On 2/7/2025 1:45 PM, Yan Zhai wrote: > Iterating through array of maps may encounter non existing keys. The > batch operation should not fail on when this happens. > > Signed-off-by: Yan Zhai Acked-by: Hou Tao

Re: [PATCH v2 bpf 1/2] bpf: skip non exist keys in generic_map_lookup_batch

2025-02-07 Thread Hou Tao
On 2/7/2025 1:45 PM, Yan Zhai wrote: > The generic_map_lookup_batch currently returns EINTR if it fails with > ENOENT and retries several times on bpf_map_copy_value. The next batch > would start from the same location, presuming it's a transient issue. > This is incorrect if a map can actually

Re: [PATCH bpf-next v2 0/3] bpf: Some fixes for nullness elision

2025-02-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf.git (master) by Alexei Starovoitov : On Tue, 4 Feb 2025 10:25:15 -0700 you wrote: > Two fixes for nullness elision. See commits for more details. > > === Changelog === > Changes from v1: > * Reword commit message in patch 1 > * Add tags > > [...] Here

Re: [PATCH 0/4] ucount: Simplify refcounting with rcuref_t.

2025-02-07 Thread Sebastian Andrzej Siewior
On 2025-02-03 16:05:21 [+0100], To linux-kernel@vger.kernel.org wrote: > I noticed that the atomic_dec_and_lock_irqsave() in put_ucounts() loops > sometimes even during boot. Something like 2-3 iterations but still. > This series replaces the refcounting with rcuref_t and adds a RCU > lookup. > Thi

Re: [PATCH] kselftest/arm64: Fix uninitialized variable warning in FPMR test

2025-02-07 Thread Mark Brown
On Fri, Feb 07, 2025 at 10:45:39AM -0800, Breno Leitao wrote: > On Fri, Feb 07, 2025 at 05:26:06PM +, Mark Brown wrote: > > On Fri, Feb 07, 2025 at 03:06:42AM -0800, Breno Leitao wrote: > > > Fix compiler warning about potentially uninitialized orig_fpmr variable: > > > testcases/fpmr_siginf

Re: [PATCH RFCv2 09/13] iommufd: Add IOMMU_OPTION_SW_MSI_START/SIZE ioctls

2025-02-07 Thread Nicolin Chen
On Fri, Feb 07, 2025 at 11:28:01AM -0400, Jason Gunthorpe wrote: > On Fri, Feb 07, 2025 at 10:30:20AM -0400, Jason Gunthorpe wrote: > > On Thu, Feb 06, 2025 at 08:26:05PM -0800, Nicolin Chen wrote: > > > Yea, I found iopt_reserve_iova() is actually missed entirely... > > > > > > While fixing this,

Re: [PATCH] kselftest/arm64: Fix uninitialized variable warning in FPMR test

2025-02-07 Thread Breno Leitao
Hello Mark, On Fri, Feb 07, 2025 at 05:26:06PM +, Mark Brown wrote: > On Fri, Feb 07, 2025 at 03:06:42AM -0800, Breno Leitao wrote: > > Fix compiler warning about potentially uninitialized orig_fpmr variable: > > > > testcases/fpmr_siginfo.c: In function ‘fpmr_present’: > > testcases/

Re: [PATCH 3/8] unwind: add sframe v2 header

2025-02-07 Thread Josh Poimboeuf
On Mon, Jan 27, 2025 at 09:33:05PM +, Weinan Liu wrote: > Add sframe header so that we know how to access the sframe section > generated by compilers. > > This is the sframe header file borrowed from the patchset [1] > Josh Poimboeuf according to sframe v2 spec [2]. > > [1]: > https://lore.k

Re: [PATCH -v2 0/7] module: Strict per-modname namespaces

2025-02-07 Thread Masahiro Yamada
On Wed, Feb 5, 2025 at 7:14 PM Petr Pavlu wrote: > > On 12/16/24 17:43, Petr Pavlu wrote: > > On 12/2/24 15:59, Peter Zijlstra wrote: > >> Hi! > >> > >> Implement a means for exports to be available only to an explicit list of > >> named > >> modules. By explicitly limiting the usage of certain e

Re: [PATCH 1/8] unwind: build kernel with sframe info

2025-02-07 Thread Josh Poimboeuf
On Tue, Feb 04, 2025 at 04:22:27PM -0800, Indu Bhagat wrote: > > +++ b/arch/Kconfig > > @@ -1736,4 +1736,12 @@ config ARCH_WANTS_PRE_LINK_VMLINUX > > An architecture can select this if it provides > > arch//tools/Makefile > > with .arch.vmlinux.o target to be linked into vmlinux. > > +

Re: [PATCH -v2 3/7] module/modpost: Add basename helper

2025-02-07 Thread Masahiro Yamada
On Tue, Dec 3, 2024 at 12:11 AM Peter Zijlstra wrote: I do not think you need this helper (at least in your purpose). You will use this helper in the 4/7 patch. Then, you will immediately revert it in the 5/7 patch. If you look at the final result, you did not need to add mod_basename() in the

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-07 Thread Josh Poimboeuf
On Fri, Feb 07, 2025 at 12:16:29PM +, Puranjay Mohan wrote: > Weinan Liu writes: > > Thank you for reporting this issue. > > I just found out that Josh also intentionally uses '>' instead of '>=' for > > the same reason > > https://lore.kernel.org/lkml/2025015257.h64ftfnorofe7cb4@jpoimboe

Re: [PATCH] kselftest/arm64: Fix uninitialized variable warning in FPMR test

2025-02-07 Thread Mark Brown
On Fri, Feb 07, 2025 at 03:06:42AM -0800, Breno Leitao wrote: > Fix compiler warning about potentially uninitialized orig_fpmr variable: > > testcases/fpmr_siginfo.c: In function ‘fpmr_present’: > testcases/fpmr_siginfo.c:68:25: warning: ‘orig_fpmr’ may be used > uninitialized in this

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Josh Poimboeuf
On Fri, Feb 07, 2025 at 11:16:45AM +0800, Yafang Shao wrote: > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > Why does this happen? > > It occurs during the KLP transition. It seems like the KLP transition > is taking too long. > > [20329703.332453] livepatch: enabling patch 'livepatc

Re: [RFC PATCH 1/2] KVM: arm64: nv: selftests: Add guest hypervisor test

2025-02-07 Thread Ganapatrao Kulkarni
On 07-02-2025 07:29 pm, Marc Zyngier wrote: On Fri, 07 Feb 2025 13:26:41 +, Ganapatrao Kulkarni wrote: + if (is_vcpu_nested(vcpu)) { + vcpu_set_reg(vcpu, KVM_ARM64_SYS_REG(SYS_CPTR_EL2), fpen); + vcpu_set_reg(vcpu, KVM_ARM64_SYS_REG(SYS_SCTLR_EL2), sct

Re: [PATCH -v2 2/7] module/modpost: Use for() loop

2025-02-07 Thread Masahiro Yamada
The commit subject prefix should be "modpost: " instead of "module/modpost: " You are touching only modpost in this patch. On Tue, Dec 3, 2024 at 12:11 AM Peter Zijlstra wrote: > > > Signed-off-by: Peter Zijlstra (Intel) > --- > scripts/mod/modpost.c |7 ++- > 1 file changed, 2 insert

Re: [PATCH -v2 4/7] module: Add module specific symbol namespace support

2025-02-07 Thread Masahiro Yamada
On Tue, Dec 3, 2024 at 12:11 AM Peter Zijlstra wrote: > > Designate the "MODULE_${modname}" symbol namespace to mean: 'only > export to the named module'. > > Notably, explicit imports of anything in the "MODULE_" space is > forbidden. Modules implicitly get the "MODULE_${modname}" namespace > add

Re: [PATCH -v2 5/7] module: Extend the MODULE_ namespace parsing

2025-02-07 Thread Masahiro Yamada
On Tue, Dec 3, 2024 at 12:11 AM Peter Zijlstra wrote: > > Instead of only accepting "MODULE_${name}", extend it with a comma > separated list of module names and add tail glob support. > > That is, something like: "MODULE_foo-*,bar" is now possible. > > Signed-off-by: Peter Zijlstra (Intel) > ---

Re: [PATCH RFCv2 09/13] iommufd: Add IOMMU_OPTION_SW_MSI_START/SIZE ioctls

2025-02-07 Thread Jason Gunthorpe
On Fri, Feb 07, 2025 at 10:30:20AM -0400, Jason Gunthorpe wrote: > On Thu, Feb 06, 2025 at 08:26:05PM -0800, Nicolin Chen wrote: > > Yea, I found iopt_reserve_iova() is actually missed entirely... > > > > While fixing this, I see a way to turn the OPTIONs back to per- > > idev, if you still prefer

Re: [PATCH v6 0/7] Buddy allocator like (or non-uniform) folio split

2025-02-07 Thread Matthew Wilcox
On Fri, Feb 07, 2025 at 09:35:27AM -0500, Zi Yan wrote: > On 7 Feb 2025, at 9:25, Matthew Wilcox wrote: > > As part of your series, I'd like to remove that limitation, so we'd need > > to allocate log_64(n - m) [ok, more complex than that, but ykwim]. So > > it's not quite "only allocate one node"

Re: [PATCH RFCv2 00/13] iommu: Add MSI mapping support with nested SMMU

2025-02-07 Thread Thomas Gleixner
On Fri, Feb 07 2025 at 10:34, Jason Gunthorpe wrote: > On Fri, Jan 10, 2025 at 07:32:16PM -0800, Nicolin Chen wrote: >> Though these two approaches feel very different on the surface, they can >> share some underlying common infrastructure. Currently, only one pair of >> sw_msi functions (prepare/c

Re: [PATCH v2 1/2] printf: convert self-test to KUnit

2025-02-07 Thread Tamir Duberstein
On Fri, Feb 7, 2025 at 6:30 AM Tamir Duberstein wrote: > > Convert the printf() self-test to a KUnit test. > > In the interest of keeping the patch reasonably-sized this doesn't > refactor the tests into proper parameterized tests - it's all one big > test case. Apologies for the version churn, I

Re: [PATCH v4 1/2] scanf: convert self-test to KUnit

2025-02-07 Thread Tamir Duberstein
On Fri, Feb 7, 2025 at 6:49 AM Tamir Duberstein wrote: > > Convert the scanf() self-test to a KUnit test. > > In the interest of keeping the patch reasonably-sized this doesn't > refactor the tests into proper parameterized tests - it's all one big > test case. Apologies for the version churn, I'

Re: [PATCH v6 0/7] Buddy allocator like (or non-uniform) folio split

2025-02-07 Thread Zi Yan
On 7 Feb 2025, at 9:25, Matthew Wilcox wrote: > On Fri, Feb 07, 2025 at 09:11:39AM -0500, Zi Yan wrote: >> Existing uniform split requires 2^(order % XA_CHUNK_SHIFT) xa_node >> allocations >> during split, when the folio needs to be split to order-0. But non-uniform >> split >> only requires at

Re: [PATCH RFCv2 00/13] iommu: Add MSI mapping support with nested SMMU

2025-02-07 Thread Jason Gunthorpe
On Fri, Jan 10, 2025 at 07:32:16PM -0800, Nicolin Chen wrote: > Though these two approaches feel very different on the surface, they can > share some underlying common infrastructure. Currently, only one pair of > sw_msi functions (prepare/compose) are provided by dma-iommu for irqchip > drivers to

Re: [PATCH RFCv2 09/13] iommufd: Add IOMMU_OPTION_SW_MSI_START/SIZE ioctls

2025-02-07 Thread Jason Gunthorpe
On Thu, Feb 06, 2025 at 08:26:05PM -0800, Nicolin Chen wrote: > Yea, I found iopt_reserve_iova() is actually missed entirely... > > While fixing this, I see a way to turn the OPTIONs back to per- > idev, if you still prefer them to be per-idev(?). Then, we can > check a given input in the set_opti

Re: [PATCH v6 0/7] Buddy allocator like (or non-uniform) folio split

2025-02-07 Thread Matthew Wilcox
On Fri, Feb 07, 2025 at 09:11:39AM -0500, Zi Yan wrote: > Existing uniform split requires 2^(order % XA_CHUNK_SHIFT) xa_node allocations > during split, when the folio needs to be split to order-0. But non-uniform > split > only requires at most 1 xa_node allocation. For example, to split an order

Re: [PATCH v6 0/7] Buddy allocator like (or non-uniform) folio split

2025-02-07 Thread Zi Yan
On 6 Feb 2025, at 3:01, Andrew Morton wrote: > On Tue, 4 Feb 2025 22:14:10 -0500 Zi Yan wrote: > >> This patchset adds a new buddy allocator like (or non-uniform) large folio >> split to reduce the total number of after-split folios, the amount of memory >> needed for multi-index xarray split, a

Re: [RFC PATCH 1/2] KVM: arm64: nv: selftests: Add guest hypervisor test

2025-02-07 Thread Marc Zyngier
On Fri, 07 Feb 2025 13:26:41 +, Ganapatrao Kulkarni wrote: > > >> + if (is_vcpu_nested(vcpu)) { > >> + vcpu_set_reg(vcpu, KVM_ARM64_SYS_REG(SYS_CPTR_EL2), fpen); > >> + vcpu_set_reg(vcpu, KVM_ARM64_SYS_REG(SYS_SCTLR_EL2), sctlr_el1); > >> + vcpu_set_reg(vcpu, KVM_A

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Petr Mladek
How does look the livepatched FuncA here? > > Does it contain changes only for Fix3? > > Or is it cummulative livepatches_funA includes both Fix1 + Fix3? > > It is cumulative livepatches_funA includes both Fix1 + Fix3. It makes sense. I have missed this in the previous

Re: [RFC PATCH 1/2] KVM: arm64: nv: selftests: Add guest hypervisor test

2025-02-07 Thread Ganapatrao Kulkarni
Hi Marc, On 07-02-2025 02:44 am, Marc Zyngier wrote: On Thu, 06 Feb 2025 16:41:19 +, Ganapatrao Kulkarni wrote: This patch adds the required changes to init vcpu in vEL2 context. Also adds a KVM selftest to execute guest code as a guest hypervisor(L1). Signed-off-by: Ganapatrao Kulkarn

Re: [PATCH net-next v18 09/25] ovpn: implement packet processing

2025-02-07 Thread Antonio Quartulli
On 05/02/2025 22:50, Sabrina Dubroca wrote: Hi Antonio, Another one I should have spotted a long time ago :( better late than never (I think..) 2025-01-13, 10:31:28 +0100, Antonio Quartulli wrote: +int ovpn_aead_encrypt(struct ovpn_peer *peer, struct ovpn_crypto_key_slot *ks, +

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-07 Thread Puranjay Mohan
Weinan Liu writes: >> After some debugging this is what I found: >> >> devtmpfsd() calls devtmpfs_work_loop() which is marked '__noreturn' and has >> an >> infinite loop. The compiler puts the `bl` to devtmpfs_work_loop() as the the >> last instruction in devtmpfsd() and therefore on entry to

Re: [PATCH v3 0/2] scanf: convert self-test to KUnit

2025-02-07 Thread Tamir Duberstein
On Fri, Feb 7, 2025 at 2:33 AM David Gow wrote: > > Thanks very much for doing this. I'm happy with these changes from a KUnit > POV. > > Two things I think we need to be careful about: > - This and the printf test are both changing the m68k configs. This is > fine, but could lead to a (harmless)

Re: [PATCH 0/2] printf: convert self-test to KUnit

2025-02-07 Thread Tamir Duberstein
On Fri, Feb 7, 2025 at 5:01 AM Rasmus Villemoes wrote: > > On Thu, Feb 06 2025, Tamir Duberstein wrote: > > > On Thu, Feb 6, 2025 at 4:27 AM Rasmus Villemoes > > wrote: > >> > >> On Tue, 4 Feb 2025 at 20:36, Tamir Duberstein wrote: > >> > > >> > This is one of just 3 remaining "Test Module" kse

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-07 Thread Petr Mladek
On Wed 2025-02-05 14:16:42, Yafang Shao wrote: > On Tue, Feb 4, 2025 at 9:05 PM Petr Mladek wrote: > > > > On Mon 2025-02-03 17:44:52, Yafang Shao wrote: > > > On Fri, Jan 31, 2025 at 9:18 PM Miroslav Benes wrote: > > > > > > > > > > > > > > > > + What exactly is meant by frequent replacements

Re: [PATCH 0/2] printf: convert self-test to KUnit

2025-02-07 Thread Rasmus Villemoes
On Thu, Feb 06 2025, Tamir Duberstein wrote: > On Thu, Feb 6, 2025 at 4:27 AM Rasmus Villemoes > wrote: >> >> On Tue, 4 Feb 2025 at 20:36, Tamir Duberstein wrote: >> > >> > This is one of just 3 remaining "Test Module" kselftests (the others >> > being bitmap and scanf), the rest having been co

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Petr Mladek
On Fri 2025-02-07 11:16:45, Yafang Shao wrote: > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > > - Temporary Loss of Patching > > > > > > During the replacement process, the old patch is set to a NOP > > > (no-operatio

Re: [v2 2/3] kernel: refactor and globalize lookup_or_create_module_kobject()

2025-02-07 Thread Rasmus Villemoes
On Thu, Feb 06 2025, Shyam Saini wrote: > lookup_or_create_module_kobject() is static and marked as __init, > this is not ideal for global usage. > > Fix this limitation by refactoring and declaring this as global: > - Refactor it by removing BUG_ON() and 'if else' construct by returning >ea

Re: [PATCH -v2 2/7] module/modpost: Use for() loop

2025-02-07 Thread Masahiro Yamada
On Tue, Dec 3, 2024 at 12:11 AM Peter Zijlstra wrote: Please add a commit description. > > Signed-off-by: Peter Zijlstra (Intel) > --- > scripts/mod/modpost.c |7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@

Re: [PATCH -v2 5/7] module: Extend the MODULE_ namespace parsing

2025-02-07 Thread Masahiro Yamada
On Tue, Dec 3, 2024 at 12:11 AM Peter Zijlstra wrote: > > Instead of only accepting "MODULE_${name}", extend it with a comma > separated list of module names and add tail glob support. > > That is, something like: "MODULE_foo-*,bar" is now possible. > > Signed-off-by: Peter Zijlstra (Intel) > ---

Re: [PATCH -v2 7/7] module: Provide EXPORT_SYMBOL_GPL_FOR() helper

2025-02-07 Thread Masahiro Yamada
On Tue, Dec 3, 2024 at 12:11 AM Peter Zijlstra wrote: > Commit description is needed. [bikeshed] Perhaps, I slightly prefer EXPORT_SYMBOL_GPL_FOR_MODULES(). > > -#define ___EXPORT_SYMBOL(sym, license, ns) \ > +/* > + * LLVM intregrated assembler refuses to merge adjacent string

Re: [PATCH 0/2] printf: convert self-test to KUnit

2025-02-06 Thread David Gow
On Thu, 6 Feb 2025 at 23:42, Tamir Duberstein wrote: > > On Thu, Feb 6, 2025 at 4:27 AM Rasmus Villemoes > wrote: > > > > On Tue, 4 Feb 2025 at 20:36, Tamir Duberstein wrote: > > > > > > This is one of just 3 remaining "Test Module" kselftests (the others > > > being bitmap and scanf), the rest

Re: [v2 2/3] kernel: refactor and globalize lookup_or_create_module_kobject()

2025-02-06 Thread Thomas Weißschuh
On 2025-02-06 21:45:37-0800, Shyam Saini wrote: > lookup_or_create_module_kobject() is static and marked as __init, > this is not ideal for global usage. FYI missing "PATCH" in patch subject. > Fix this limitation by refactoring and declaring this as global: > - Refactor it by removing BUG_ON()

Re: [PATCH v3 0/2] scanf: convert self-test to KUnit

2025-02-06 Thread David Gow
On Wed, 5 Feb 2025 at 03:26, Tamir Duberstein wrote: > > This is one of just 3 remaining "Test Module" kselftests (the others > being bitmap and printf), the rest having been converted to KUnit. In > addition to the enclosed patch, please consider this an RFC on the > removal of the "Test Module"

Re: [PATCHv2 net 1/2] bonding: fix incorrect MAC address setting to receive NS messages

2025-02-06 Thread Hangbin Liu
On Thu, Feb 06, 2025 at 05:19:34PM -0800, Jay Vosburgh wrote: > I think this now deserves some commentary in the code. Not > because this function itself is unclear, but because there's the > similarly-named slave_set_ns_maddr() (singular, not plural as in this > patch) that will behave in a

Re: [RFC PATCH 00/39] 1G page support for guest_memfd

2025-02-06 Thread Ackerley Tng
Amit Shah writes: >> >> >> Thanks all your help and comments during the guest_memfd upstream >> calls, >> and thanks for the help from AMD. >> >> Extending mmap() support from Fuad with 1G page support introduces >> more >> states that made it more complicated (at least for me). >> >> I'm mod

Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-06 Thread Shyam Saini
Hi Everyone, On Wed, Feb 05, 2025 at 09:43:12AM +0100, Rasmus Villemoes wrote: > On Mon, Feb 03 2025, Shyam Saini wrote: > > > Move the following to module.h to allow common usages: > > - lookup_or_create_module_kobject() > > - to_module_attr > > - to_module_kobject > > > > This makes lookup_

Re: [PATCH RFCv2 09/13] iommufd: Add IOMMU_OPTION_SW_MSI_START/SIZE ioctls

2025-02-06 Thread Nicolin Chen
On Wed, Jan 29, 2025 at 10:58:00AM -0400, Jason Gunthorpe wrote: > On Wed, Jan 29, 2025 at 02:44:12PM +0100, Eric Auger wrote: > > On 1/11/25 4:32 AM, Nicolin Chen wrote: > > > For systems that require MSI pages to be mapped into the IOMMU translation > > > the IOMMU driver provides an IOMMU_RESV_S

Re: [PATCH bpf] bpf: skip non existing key in generic_map_lookup_batch

2025-02-06 Thread Yan Zhai
On Thu, Feb 6, 2025 at 2:20 AM Yan Zhai wrote: > > On Thu, Feb 6, 2025 at 12:40 AM Hou Tao wrote: > > > > > > > > Yes, the retry logic doesn't change the previous key. Thanks for the > > clarifying. > > > And by "skipping to the next key", it's simply > > > > > > if (err == -ENOENT) > > >

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-06 Thread Yafang Shao
On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > The atomic replace livepatch mechanism was introduced to handle scenarios > > where we want to unload a specific livepatch without unloading others. > > However, its current i

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-06 Thread Josh Poimboeuf
On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > The atomic replace livepatch mechanism was introduced to handle scenarios > where we want to unload a specific livepatch without unloading others. > However, its current implementation has significant shortcomings, making > it less than

Re: [PATCHv2 net 1/2] bonding: fix incorrect MAC address setting to receive NS messages

2025-02-06 Thread Jay Vosburgh
Hangbin Liu wrote: >When validation on the backup slave is enabled, we need to validate the >Neighbor Solicitation (NS) messages received on the backup slave. To >receive these messages, the correct destination MAC address must be added >to the slave. However, the target in bonding is a unicast a

Re: [PATCH RFT v14 2/8] Documentation: userspace-api: Add shadow stack API documentation

2025-02-06 Thread Deepak Gupta
On Thu, Feb 06, 2025 at 11:38:04AM +, Mark Brown wrote: There are a number of architectures with shadow stack features which we are presenting to userspace with as consistent an API as we can (though there are some architecture specifics). Especially given that there are some important consid

Re: [RFC PATCH 1/2] KVM: arm64: nv: selftests: Add guest hypervisor test

2025-02-06 Thread Marc Zyngier
On Thu, 06 Feb 2025 16:41:19 +, Ganapatrao Kulkarni wrote: > > This patch adds the required changes to init vcpu in vEL2 context. > Also adds a KVM selftest to execute guest code as a guest hypervisor(L1). > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/testing/selftests/kvm/Makefile.

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-06 Thread Song Liu
On Wed, Feb 5, 2025 at 6:55 PM Yafang Shao wrote: [...] > > I think we should first understand why the trampoline is not > > freed. > > IIUC, the fexit works as follows, > > bpf_trampoline > + __bpf_tramp_enter >+ percpu_ref_get(&tr->pcref); > > + call do_exit() > > + __bpf_t

Re: [PATCH rcu 6/5] Make RCU watch ct_kernel_exit_state() warning

2025-02-06 Thread Boqun Feng
On Thu, Feb 06, 2025 at 02:15:09AM -0800, Paul E. McKenney wrote: > The WARN_ON_ONCE() in ct_kernel_exit_state() follows the call to > ct_state_inc(), which means that RCU is not watching this WARN_ON_ONCE(). > This can (and does) result in extraneous lockdep warnings when this > WARN_ON_ONCE() tri

Re: [RESEND] [PATCH bpf-next 2/3] bpf: Overwrite the element in hash map atomically

2025-02-06 Thread Toke Høiland-Jørgensen
Hou Tao writes: > +cc Cody Haas > > Sorry for the resend. I sent the reply in the HTML format. > > On 2/4/2025 4:28 PM, Hou Tao wrote: >> Currently, the update of existing element in hash map involves two >> steps: >> 1) insert the new element at the head of the hash list >> 2) remove the old ele

Re: [RFC PATCH 2/2] KVM: arm64: nv: selftests: Access VNCR mapped registers

2025-02-06 Thread Marc Zyngier
On Thu, 06 Feb 2025 16:41:20 +, Ganapatrao Kulkarni wrote: > > With NV2 enabled, some of the EL1/EL2/EL12 register accesses are > transformed to memory accesses. This test code accesses all those > registers in guest code to validate that they are not trapped to L0. > Traps to L0 are invisib

Re: [RFC PATCH 0/2] Add NV Selftest cases

2025-02-06 Thread Ganapatrao Kulkarni
On 06-02-2025 10:11 pm, Ganapatrao Kulkarni wrote: In this patch seried, modified kvm selftests code to enable guest code to run in vEL2(As guest Hypervisor). Also added test cases to test guest code booting in vEL2 and register access of VNCR mapped registers. This patchset is created as per

Re: [PATCH] virtio: Remove virtio devices on device_shutdown()

2025-02-06 Thread Eric Auger
On 2/6/25 11:04 AM, Kirill A. Shutemov wrote: > On Thu, Feb 06, 2025 at 09:59:58AM +0100, Eric Auger wrote: >> Hi, >> >> On 2/4/25 12:46 PM, Eric Auger wrote: >>> Hi, >>> >>> On 2/3/25 3:48 PM, Michael S. Tsirkin wrote: On Fri, Jan 31, 2025 at 10:53:15AM +0100, Eric Auger wrote: > Hi Ki

Re: [PATCH net-next v4 14/17] net: pktgen: hex32_arg/num_arg error out in case no characters are available

2025-02-06 Thread Simon Horman
On Wed, Feb 05, 2025 at 02:11:50PM +0100, Peter Seiderer wrote: > In hex32_arg() and num_arg() error out in case no characters are available > (maxlen = 0). > > Signed-off-by: Peter Seiderer Hi Peter, This patch and the following could benefit from: * A more succinct subject * An explanation o

Re: [PATCH net-next v4 13/17] net: pktgen: fix access outside of user given buffer in pktgen_if_write()

2025-02-06 Thread Simon Horman
common pattern' (suggested by Paolo Abeni) > - factored out patch 'net: pktgen: remove extra tmp variable (re-use len > instead)' (suggested by Paolo Abeni) > - factored out patch 'net: pktgen: remove some superfluous variable > initializing' (suggested by Pa

Re: [PATCH 0/2] printf: convert self-test to KUnit

2025-02-06 Thread Tamir Duberstein
On Thu, Feb 6, 2025 at 4:27 AM Rasmus Villemoes wrote: > > On Tue, 4 Feb 2025 at 20:36, Tamir Duberstein wrote: > > > > This is one of just 3 remaining "Test Module" kselftests (the others > > being bitmap and scanf), the rest having been converted to KUnit. > > > > I tested this using: > > > > $

Re: [PATCH 0/8] unwind, arm64: add sframe unwinder for kernel

2025-02-06 Thread Weinan Liu
> After some debugging this is what I found: > > devtmpfsd() calls devtmpfs_work_loop() which is marked '__noreturn' and has an > infinite loop. The compiler puts the `bl` to devtmpfs_work_loop() as the the > last instruction in devtmpfsd() and therefore on entry to > devtmpfs_work_loop(), > LR p

Re: [PATCH net-next v4 00/17] Some pktgen fixes/improvments

2025-02-06 Thread Simon Horman
and code review I > detected that the /proc/net/pktgen/... parsing logic does not honour the > user given buffer bounds (resulting in out-of-bounds access). > > This can be observed e.g. by the following simple test (sometimes the > old/'longer' previous value is re-read

Re: [PATCH net-next v4 09/17] net: pktgen: align some variable declarations to the most common pattern

2025-02-06 Thread Simon Horman
On Wed, Feb 05, 2025 at 02:11:45PM +0100, Peter Seiderer wrote: > Align some variable declarations (in get_imix_entries and get_labels) to > the most common pattern (int instead of ssize_t/long) and adjust function > return value accordingly. > > Signed-off-by: Peter Seiderer Hi Peter, These co

Re: [PATCH net-next v4 08/17] net: pktgen: use defines for the various dec/hex number parsing digits lengths

2025-02-06 Thread Simon Horman
On Wed, Feb 05, 2025 at 02:11:44PM +0100, Peter Seiderer wrote: > Use defines for the various dec/hex number parsing digits lengths > (hex32_arg/num_arg calls). > > Signed-off-by: Peter Seiderer > --- > Changes v3 -> v4 > - new patch (suggested by Simon Horman) Reviewed-by: Simon Horman

Re: [PATCH net-next v4 10/17] net: pktgen: remove extra tmp variable (re-use len instead)

2025-02-06 Thread Simon Horman
On Wed, Feb 05, 2025 at 02:11:46PM +0100, Peter Seiderer wrote: > Remove extra tmp variable in pktgen_if_write (re-use len instead). > > Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman

Re: [PATCH net-next v4 11/17] net: pktgen: remove some superfluous variable initializing

2025-02-06 Thread Simon Horman
On Wed, Feb 05, 2025 at 02:11:47PM +0100, Peter Seiderer wrote: > Remove some superfluous variable initializing before hex32_arg call (as the > same init is done here already). > > Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman

Re: [PATCH net-next v4 12/17] net: pktgen: fix mpls maximum labels list parsing

2025-02-06 Thread Simon Horman
On Wed, Feb 05, 2025 at 02:11:48PM +0100, Peter Seiderer wrote: > Fix mpls maximum labels list parsing up to MAX_MPLS_LABELS/16 entries > (instead of up to MAX_MPLS_LABELS - 1). > > Fixes: "Fixes: " has a special meaning, it is recognised as a tag by tooling, and implies a bug fix. Please consid

Re: [RFC PATCH 00/39] 1G page support for guest_memfd

2025-02-06 Thread Amit Shah
On Mon, 2025-02-03 at 08:35 +, Ackerley Tng wrote: > Amit Shah writes: > > > Hey Ackerley, > > Hi Amit, > > > On Tue, 2024-09-10 at 23:43 +, Ackerley Tng wrote: > > > Hello, > > > > > > This patchset is our exploration of how to support 1G pages in > > > guest_memfd, and > > > how the

Re: [PATCH] virtio: Remove virtio devices on device_shutdown()

2025-02-06 Thread Kirill A. Shutemov
On Thu, Feb 06, 2025 at 09:59:58AM +0100, Eric Auger wrote: > Hi, > > On 2/4/25 12:46 PM, Eric Auger wrote: > > Hi, > > > > On 2/3/25 3:48 PM, Michael S. Tsirkin wrote: > >> On Fri, Jan 31, 2025 at 10:53:15AM +0100, Eric Auger wrote: > >>> Hi Kirill, Michael > >>> > >>> On 8/8/24 9:51 AM, Kirill

Re: [PATCH 0/2] printf: convert self-test to KUnit

2025-02-06 Thread Rasmus Villemoes
On Tue, 4 Feb 2025 at 20:36, Tamir Duberstein wrote: > > This is one of just 3 remaining "Test Module" kselftests (the others > being bitmap and scanf), the rest having been converted to KUnit. > > I tested this using: > > $ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 print

Re: [PATCH] virtio: Remove virtio devices on device_shutdown()

2025-02-06 Thread Eric Auger
Hi, On 2/4/25 12:46 PM, Eric Auger wrote: > Hi, > > On 2/3/25 3:48 PM, Michael S. Tsirkin wrote: >> On Fri, Jan 31, 2025 at 10:53:15AM +0100, Eric Auger wrote: >>> Hi Kirill, Michael >>> >>> On 8/8/24 9:51 AM, Kirill A. Shutemov wrote: Hongyu reported a hang on kexec in a VM. QEMU reported i

Re: [PATCH bpf] bpf: skip non existing key in generic_map_lookup_batch

2025-02-06 Thread Yan Zhai
On Thu, Feb 6, 2025 at 12:40 AM Hou Tao wrote: > > Hi, > > On 2/6/2025 12:57 AM, Yan Zhai wrote: > > The generic_map_lookup_batch currently returns EINTR if it fails with > > ENOENT and retries several times on bpf_map_copy_value. The next batch > > would start from the same location, presuming it

Re: [PATCH v6 0/7] Buddy allocator like (or non-uniform) folio split

2025-02-06 Thread Andrew Morton
On Tue, 4 Feb 2025 22:14:10 -0500 Zi Yan wrote: > This patchset adds a new buddy allocator like (or non-uniform) large folio > split to reduce the total number of after-split folios, the amount of memory > needed for multi-index xarray split, and keep more large folios after a split. It would b

Re: [PATCH bpf] bpf: skip non existing key in generic_map_lookup_batch

2025-02-05 Thread Hou Tao
Hi, On 2/6/2025 12:57 AM, Yan Zhai wrote: > The generic_map_lookup_batch currently returns EINTR if it fails with > ENOENT and retries several times on bpf_map_copy_value. The next batch > would start from the same location, presuming it's a transient issue. > This is incorrect if a map can actual

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-05 Thread Yafang Shao
On Thu, Feb 6, 2025 at 1:59 AM Song Liu wrote: > > On Wed, Feb 5, 2025 at 6:43 AM Yafang Shao wrote: > > > > On Tue, Feb 4, 2025 at 5:53 AM Song Liu wrote: > > > > > > On Mon, Feb 3, 2025 at 1:45 AM Yafang Shao wrote: > > > [...] > > > > > > > > If you’re managing a large fleet of servers, this

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-05 Thread Yafang Shao
On Thu, Feb 6, 2025 at 12:03 AM Petr Mladek wrote: > > On Wed 2025-02-05 10:54:47, Yafang Shao wrote: > > On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > > > > > On Mon 2025-01-27 23:34:50, Yafang Shao wrote: > > > > On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > > > > > > > > > O

Re: [PATCH net] selftests: mptcp: connect: -f: no reconnect

2025-02-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 04 Feb 2025 23:19:53 +0100 you wrote: > The '-f' parameter is there to force the kernel to emit MPTCP FASTCLOSE > by closing the connection with unread bytes in the receive queue. > > The xdisconnect() helper was

Re: [PATCH] selftests: bpf: Support dynamic linking LLVM if static not available

2025-02-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Thu, 30 Jan 2025 15:33:45 -0700 you wrote: > Since 67ab80a01886 ("selftests/bpf: Prefer static linking for LLVM > libraries"), only statically linking test_progs is supported. However, > some distros only provide a

Re: [PATCH] selftests: bpf: Support dynamic linking LLVM if static not available

2025-02-05 Thread Andrii Nakryiko
On Thu, Jan 30, 2025 at 2:34 PM Daniel Xu wrote: > > Since 67ab80a01886 ("selftests/bpf: Prefer static linking for LLVM > libraries"), only statically linking test_progs is supported. However, > some distros only provide a dynamically linkable LLVM. > > This commit adds a fallback for dynamically

Re: [PATCH v2 02/13] virtio_net: simplify virtnet_set_affinity()

2025-02-05 Thread Nick Child
On Tue, Jan 28, 2025 at 11:46:31AM -0500, Yury Norov wrote: > The inner loop may be replaced with the dedicated for_each_online_cpu_wrap. > It helps to avoid setting the same bits in the @mask more than once, in > case of group_size is greater than number of online CPUs. nit: Looking at the previo

Re: [PATCH RFCv2 00/13] iommu: Add MSI mapping support with nested SMMU

2025-02-05 Thread Nicolin Chen
On Wed, Feb 05, 2025 at 02:49:04PM -0800, Jacob Pan wrote: > > There have been two approaches to solve this problem: > > 1. Create an identity mapping in the stage-1. VMM could insert a few > > RMRs (Reserved Memory Regions) in guest's IORT. Then the guest kernel > > would fetch these RMR entries f

Re: [PATCH RFCv2 00/13] iommu: Add MSI mapping support with nested SMMU

2025-02-05 Thread Jacob Pan
Hi Nicolin, On Fri, 10 Jan 2025 19:32:16 -0800 Nicolin Chen wrote: > [ Background ] > On ARM GIC systems and others, the target address of the MSI is > translated by the IOMMU. For GIC, the MSI address page is called > "ITS" page. When the IOMMU is disabled, the MSI address is programmed > to th

Re: Re: [PATCH 2/2] libbpf: BPF programs dynamic loading and attaching

2025-02-05 Thread Andrii Nakryiko
On Tue, Jan 28, 2025 at 3:08 PM Martin Kelly wrote: > > On Fri, 2025-01-24 at 10:31 -0800, Andrii Nakryiko wrote: > > > On Wed, Jan 22, 2025 at 1:53 PM Slava Imameev > > > wrote: > > > > > > > > > > BPF programs designated as dynamically loaded can be loaded and > > > > > attached independently a

Re: [PATCH net-next v18 09/25] ovpn: implement packet processing

2025-02-05 Thread Sabrina Dubroca
Hi Antonio, Another one I should have spotted a long time ago :( 2025-01-13, 10:31:28 +0100, Antonio Quartulli wrote: > +int ovpn_aead_encrypt(struct ovpn_peer *peer, struct ovpn_crypto_key_slot > *ks, > + struct sk_buff *skb) > +{ > + const unsigned int tag_size = crypto_a

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-05 Thread Song Liu
On Wed, Feb 5, 2025 at 6:43 AM Yafang Shao wrote: > > On Tue, Feb 4, 2025 at 5:53 AM Song Liu wrote: > > > > On Mon, Feb 3, 2025 at 1:45 AM Yafang Shao wrote: > > [...] > > > > > > If you’re managing a large fleet of servers, this issue is far from > > > negligible. > > > > > > > > > > > > Can

Re: [PATCH] selftests: pidfd: Fix compiling errors and warning

2025-02-05 Thread I Hsin Cheng
On Wed, Feb 05, 2025 at 01:07:56PM +0100, Peter Seiderer wrote: > Hello *, > > On Wed, 5 Feb 2025 13:39:26 +0800, I Hsin Cheng > wrote: > > > When compiling selftests files under tools/testing/selftests/pidfd/ , > > some compiling errors and warnings will pop out as the following. > > > > C

  1   2   3   4   5   6   7   8   9   10   >